Also, iwyu
refactor: Remove unused circular include dependency from kernel/coinstats.cpp #28773
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2311-no-circ- changing 3 files +3 −10-
maflcko commented at 10:29 AM on November 2, 2023: member
-
refactor: Remove unused circular include dependency from kernel/coinstats.cpp faacc56856
-
DrahtBot commented at 10:29 AM on November 2, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
- DrahtBot added the label Refactoring on Nov 2, 2023
-
fanquake commented at 10:31 AM on November 2, 2023: member
https://github.com/bitcoin/bitcoin/pull/28773/checks?check_run_id=18295730879:
A new circular dependency in the form of "kernel/coinstats -> node/blockstorage -> validation -> kernel/coinstats" appears to have been introduced.
-
maflcko commented at 10:47 AM on November 2, 2023: member
A new circular dependency in the form of "kernel/coinstats -> node/blockstorage -> validation -> kernel/coinstats" appears to have been introduced.
Yeah, this is identical to, and already tracked as
"node/blockstorage -> validation -> node/blockstorage". I guess I can close for now, until the other one is fixed. - maflcko closed this on Nov 2, 2023
- maflcko deleted the branch on Nov 2, 2023
- bitcoin locked this on Nov 1, 2024
Labels