The signing test for the large miniscript can sometimes take longer than the 30 second timeout, depending on the load on my system. Increasing it to 90 seconds seems to be good enough.
tests: Increase wallet_miniscript.py rpc timeout to 90 seconds #28820
pull achow101 wants to merge 1 commits into bitcoin:master from achow101:increase-wallet-miniscript-timeout changing 1 files +1 −0-
achow101 commented at 11:33 PM on November 7, 2023: member
-
6559e4d27a
tests: Increase wallet_miniscript.py rpc timeout to 90 seconds
The signing test for the large miniscript can sometimes take longer than the 30 second timeout, depending on the load on my system. Increasing it to 90 seconds seems to be good enough.
-
DrahtBot commented at 11:33 PM on November 7, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK kevkevinpal, maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Nov 7, 2023
-
kevkevinpal commented at 12:56 AM on November 8, 2023: contributor
looks like the default is 60 seconds according to this https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/test_framework.py#L103
but increasing seems fine ACK 6559e4d
-
maflcko commented at 7:48 AM on November 8, 2023: member
lgtm ACK 6559e4d27ac9e8344d1211239cffab427b94bc23
- fanquake merged this on Nov 8, 2023
- fanquake closed this on Nov 8, 2023
- bitcoin locked this on Nov 7, 2024
Contributors
Labels