test: Add missing wait for version to be sent in add_outbound_p2p_connection #28822

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2311-test-sync-ver- changing 1 files +1 −0
  1. maflcko commented at 10:37 AM on November 8, 2023: member

    Can be tested with:

    diff --git a/test/functional/test_framework/p2p.py b/test/functional/test_framework/p2p.py
    index b1ed97b794..eb4f72c6b6 100755
    --- a/test/functional/test_framework/p2p.py
    +++ b/test/functional/test_framework/p2p.py
    @@ -205,6 +205,7 @@ class P2PConnection(asyncio.Protocol):
             assert not self._transport
             logger.debug("Connected & Listening: %s:%d" % (self.dstaddr, self.dstport))
             self._transport = transport
    +        import time;time.sleep(.1);
             if self.on_connection_send_msg:
                 self.send_message(self.on_connection_send_msg)
                 self.on_connection_send_msg = None  # Never used again
    

    Found and reported by mzumsande in #28782#pullrequestreview-1718560252

  2. test: Add missing wait for version to be sent in add_outbound_p2p_connection faa2ad88bc
  3. DrahtBot commented at 10:37 AM on November 8, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK mzumsande

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Nov 8, 2023
  5. fanquake requested review from mzumsande on Nov 8, 2023
  6. mzumsande commented at 10:13 PM on November 8, 2023: contributor

    ACK faa2ad88bc01bd434ce19fde19bcc5c78431702f

  7. fanquake merged this on Nov 9, 2023
  8. fanquake closed this on Nov 9, 2023

  9. maflcko deleted the branch on Nov 9, 2023
  10. kwvg referenced this in commit 88cfb153fc on Oct 15, 2024
  11. kwvg referenced this in commit d0804d4bf0 on Oct 16, 2024
  12. PastaPastaPasta referenced this in commit dd629cf0eb on Oct 22, 2024
  13. bitcoin locked this on Nov 8, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 09:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me