wallet: refactor: remove unused SignatureData instances in spkm’s FillPSBT methods #28833

1. 
   theStack commented at 2:25 pm on November 9, 2023: contributor

   These are filled with signature data from a PSBT input, but not used anywhere after, hence they can be removed. Note that the same code is in the SignPSBTInput function where the sigdata result is indeed used.
2. 
   DrahtBot commented at 2:25 pm on November 9, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	brunoerg, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28710 (Remove the legacy wallet and BDB dependency by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Wallet on Nov 9, 2023
4. DrahtBot added the label CI failed on Jan 16, 2024
5. wallet: remove unused `SignatureData` instances in spkm's `FillPSBT` methods

   These are filled with signature data from a PSBT input, but not used anywhere
   after, hence they can be removed.

   e2ad343f69
6. theStack force-pushed on Jan 22, 2024
7. DrahtBot removed the label CI failed on Jan 22, 2024
8. brunoerg approved
9. 
   brunoerg commented at 2:49 pm on February 6, 2024: contributor

   crACK e2ad343f69af4f924b22dccf94a52b6431ef6e3c

   I checked that FillSignatureData only modifies FillSignatureData and does not affect anything from the PSBTInput itself. Since SignatureData instances are not used in spkm’s FillPSBTmethods, makes sense to remove them. Also, FillSignatureData could return SignatureData instead of void.

10. 
    achow101 commented at 6:24 pm on February 6, 2024: member

    ACK e2ad343f69af4f924b22dccf94a52b6431ef6e3c
11. achow101 merged this on Feb 6, 2024
12. achow101 closed this on Feb 6, 2024

    ---

13. theStack deleted the branch on Feb 6, 2024

Contributors
theStack DrahtBot brunoerg achow101

Labels
Wallet