These are filled with signature data from a PSBT input, but not used anywhere after, hence they can be removed. Note that the same code is in the SignPSBTInput function where the sigdata result is indeed used.
wallet: refactor: remove unused `SignatureData` instances in spkm's `FillPSBT` methods #28833
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202311-wallet-remove_unused_SignatureData_instances changing 1 files +0 −4-
theStack commented at 2:25 PM on November 9, 2023: contributor
-
DrahtBot commented at 2:25 PM on November 9, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #28710 (Remove the legacy wallet and BDB dependency by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Wallet on Nov 9, 2023
- DrahtBot added the label CI failed on Jan 16, 2024
-
e2ad343f69
wallet: remove unused `SignatureData` instances in spkm's `FillPSBT` methods
These are filled with signature data from a PSBT input, but not used anywhere after, hence they can be removed.
- theStack force-pushed on Jan 22, 2024
- DrahtBot removed the label CI failed on Jan 22, 2024
- brunoerg approved
-
brunoerg commented at 2:49 PM on February 6, 2024: contributor
crACK e2ad343f69af4f924b22dccf94a52b6431ef6e3c
I checked that
FillSignatureDataonly modifiesFillSignatureDataand does not affect anything from thePSBTInputitself. SinceSignatureDatainstances are not used in spkm'sFillPSBTmethods, makes sense to remove them. Also,FillSignatureDatacould returnSignatureDatainstead of void. -
achow101 commented at 6:24 PM on February 6, 2024: member
ACK e2ad343f69af4f924b22dccf94a52b6431ef6e3c
- achow101 merged this on Feb 6, 2024
- achow101 closed this on Feb 6, 2024
- theStack deleted the branch on Feb 6, 2024
- bitcoin locked this on Feb 5, 2025
