Better Fee UI #289

In 3 commits: Make the fee error/dialog messages much clearer.

Update fee policy to be much more customizable. This changes nTransactionFee into nBaseTransactionFee and nPerKBTransactionFee where nBaseTransactionFee is applied to each transaction once and nPerKBTransactionFee is applied per KB to each transaction. Also, fOverrideTransactionFee has been added to allow the ignoring of GetMinFee() when creating transactions.

Add setautocommit, reject transaction and committransaction. Here is the help for setautocommit: If <autocommit> is false, the send* functions will return a txid, which must be manually committed instead of being immediately committed. Once a new transaction has been created, you can get information about it by using gettransaction <txid>. It can then be commited or rejected using committransaction <txid> or rejecttransaction <txid> respectively.

Forum thread at http://forum.bitcoin.org/index.php?topic=10923.0

I assume The Right Thing happens if I:

setautocommit false send.... stop

(the Right Thing being that when I restart the txid from the send is just completely unknown and the coins that were in committed state when bitcoin stopped are available to be sent?)

Yes, setautocommit false stores txes in a temporary map local to rpc.cpp (static std::map<uint256, CWalletTx> mapTempTransactions; static std::map<uint256, CReserveKey> mapTempPoolKeys; ) so those will not touch wallet until committransaction is called.

A lot of good stuff in here, but

• standard (but BIG) usability problem: if we make it easy for users to ignore recommended fee, then we just made it very easy to create transactions that may /never/ confirm. "unspending" is a very hard problem and not implemented, so any feature that makes it easy to create "limbo coins" becomes a support nightmare once users who do not know what they're doing un-check that box.

Also,

• should be separated into multiple pulls
• changes fee behavior, and should be dicussed with community

True, maybe that option should be removed and just the first and second commits suggested. Also, Im too lazy to do multiple pulls, and this was specifically written so that it does not change any fee behavior, only make it more customizable....plus it seems like the community never feels like discussing pull requests, only crazy theoretical problems that never make any sense to begin with.

Closing this due to several bugs found that I dont have time to fix nor the desire to fix. Going forward I'd like to see: 2. as part of a larger upgrade to fees, which Im sure it will be.

1. probably never, though the part which upgrades the various info in the options page might be helpful as its much clearer.
2. whenever I get the chance to rebase onto master, this might be useful for various uses in the future.