brew: serfloat_tests tests fail on Linux

chenrui333 commented at 9:29 pm on November 25, 2023: none

While upgrading sqlite to 3.44.1, we’ve found some regression test failure

  0  ==> /home/linuxbrew/.linuxbrew/Cellar/bitcoin/25.1/bin/test_bitcoin
  1  Running 557 test cases...
  2  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3933824172291540 != 0]
  3  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [1522707584769707 != 0]
  4  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [374125094843894 != 0]
  5  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224752452531391473 != 9223372036854775808]
  6  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224453948959884676 != 9223372036854775808]
  7  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [1499667794006317 != 0]
  8  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224331761679445658 != 9223372036854775808]
  9  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3797636946379321 != 0]
 10  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9223398623961477110 != 9223372036854775808]
 11  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226093353937622967 != 9223372036854775808]
 12  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2752882566690523 != 0]
 13  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3723747459500560 != 0]
 14  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225356954738111761 != 9223372036854775808]
 15  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225806041580832942 != 9223372036854775808]
 16  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2271153029146949 != 0]
 17  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [4376016398283426 != 0]
 18  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225563520470924990 != 9223372036854775808]
 19  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3792265053704840 != 0]
 20  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [347207825541012 != 0]
 21  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [1168780731377488 != 0]
 22  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2965083162628722 != 0]
 23  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [477276241038670 != 0]
 24  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226363870467543079 != 9223372036854775808]
 25  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224746877852232862 != 9223372036854775808]
 26  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226238373835790958 != 9223372036854775808]
 27  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [86929691005609 != 0]
 28  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2942449861391460 != 0]
 29  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225340393284352575 != 9223372036854775808]
 30  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225050029841971585 != 9223372036854775808]
 31  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224809070091070000 != 9223372036854775808]
 32  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226554750137448828 != 9223372036854775808]
 33  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9227206754791686520 != 9223372036854775808]
 34  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9223980810041164974 != 9223372036854775808]
 35  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225698934482478456 != 9223372036854775808]
 36  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224208306055926285 != 9223372036854775808]
 37  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224186127956266452 != 9223372036854775808]
 38  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225925802284182095 != 9223372036854775808]
 39  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9223928551772939627 != 9223372036854775808]
 40  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3623033616195084 != 0]
 41  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9227216650817270942 != 9223372036854775808]
 42  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2577780403690387 != 0]
 43  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3162417420186166 != 0]
 44  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226497980833609526 != 9223372036854775808]
 45  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [1749660543498179 != 0]
 46  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3455322245295498 != 0]
 47  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225396717339753688 != 9223372036854775808]
 48  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9227165447309289704 != 9223372036854775808]
 49  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [285805572034508 != 0]
 50  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9227695892072904035 != 9223372036854775808]
 51  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225036844246367060 != 9223372036854775808]
 52  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [1489754990652608 != 0]
 53  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2481047884625142 != 0]
 54  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [373879107397762 != 0]
 55  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [1892762544245242 != 0]
 56  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225131741498636851 != 9223372036854775808]
 57  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2122077632069880 != 0]
 58  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3143403121085682 != 0]
 59  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [556361616820672 != 0]
 60  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225471046715572063 != 9223372036854775808]
 61  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9223684768192724281 != 9223372036854775808]
 62  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9223919368142746580 != 9223372036854775808]
 63  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2807902341394841 != 0]
 64  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226183700267453367 != 9223372036854775808]
 65  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [4208408803602456 != 0]
 66  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2584598909334219 != 0]
 67  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2802886078797456 != 0]
 68  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224532097991487612 != 9223372036854775808]
 69  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225818771138588963 != 9223372036854775808]
 70  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9227245848796452352 != 9223372036854775808]
 71  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225679896850173516 != 9223372036854775808]
 72  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [830080942264534 != 0]
 73  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226899665892436436 != 9223372036854775808]
 74  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2828023962503881 != 0]
 75  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3180151609841506 != 0]
 76  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2167313471010248 != 0]
 77  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225134207477076915 != 9223372036854775808]
 78  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225780277094680592 != 9223372036854775808]
 79  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [286299190892951 != 0]
 80  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224328452336866620 != 9223372036854775808]
 81  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226064406087290845 != 9223372036854775808]
 82  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9223718336233924552 != 9223372036854775808]
 83  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9227489670875707081 != 9223372036854775808]
 84  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [4369532746588483 != 0]
 85  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224573448428907612 != 9223372036854775808]
 86  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3988970319706739 != 0]
 87  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224616559044156218 != 9223372036854775808]
 88  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2481223246488553 != 0]
 89  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3363675693216343 != 0]
 90  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226429786598058904 != 9223372036854775808]
 91  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9223780980916297294 != 9223372036854775808]
 92  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [4102750784661755 != 0]
 93  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9227291611060258409 != 9223372036854775808]
 94  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224356517516059325 != 9223372036854775808]
 95  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2363239654391114 != 0]
 96  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [1640763681047664 != 0]
 97  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2826021723578244 != 0]
 98  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226410104325047901 != 9223372036854775808]
 99  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9227207594627212218 != 9223372036854775808]
100  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [529868061618094 != 0]
101  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2981046670492395 != 0]
102  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9227322033479241850 != 9223372036854775808]
103  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [1957399855560058 != 0]
104  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225727899537617691 != 9223372036854775808]
105  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224424688918652585 != 9223372036854775808]
106  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224929520479068927 != 9223372036854775808]
107  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [4083948250835466 != 0]
108  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224255440711596839 != 9223372036854775808]
109  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [1536163377508301 != 0]
110  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [628099886525908 != 0]
111  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [220392387946650 != 0]
112  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [133866554814199 != 0]
113  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224236984710524971 != 9223372036854775808]
114  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [740098587902311 != 0]
115  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2772860282713608 != 0]
116  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3400602984693832 != 0]
117  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [1346799403187160 != 0]
118  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9223700398369721559 != 9223372036854775808]
119  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226882515455163225 != 9223372036854775808]
120  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9227001840494683347 != 9223372036854775808]
121  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2198605537427845 != 0]
122  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [660414779065500 != 0]
123  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9223959632152251076 != 9223372036854775808]
124  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [243100932865172 != 0]
125  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [1571661754352886 != 0]
126  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225243564930984440 != 9223372036854775808]
127  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224550485051700170 != 9223372036854775808]
128  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9224479748223918009 != 9223372036854775808]
129  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [4382210717923318 != 0]
130  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [3944138426916343 != 0]
131  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [208988949884434 != 0]
132  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9227568837147265561 != 9223372036854775808]
133  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [2093079429728088 != 0]
134  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226815136446339015 != 9223372036854775808]
135  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [4368363772158552 != 0]
136  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [4423145887259664 != 0]
137  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9227843128568109142 != 9223372036854775808]
138  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9226441322270375442 != 9223372036854775808]
139  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9225838125615508474 != 9223372036854775808]
140  test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check v == v2 has failed [9223487462337045591 != 9223372036854775808]
141  
142  *** 239 failures are detected in the test module "Bitcoin Core Test Suite"

full build log, https://github.com/Homebrew/homebrew-core/actions/runs/6986063366/job/19011552060?pr=155161 relates to Homebrew/homebrew-core#155161

jonatack commented at 9:38 pm on November 26, 2023: contributor

Upgraded to sqlite3 version 3.44.1 (2023-11-22 14:18:12 d295f48e 64-bit) on ARM64 macOS 13.6 Ventura.

The unit test suite is green for me on v25.1 and current master, both built from source with clang 17.

maflcko commented at 9:24 am on November 27, 2023: member

So this is homebrew on Linux?

Please add exact steps to reproduce, otherwise little can be done here.

Also, this error seems unrelated to sqlite, because the serfloat tests don’t use sqlite.

fanquake added the label Linux/Unix on Nov 27, 2023

maflcko commented at 6:27 pm on November 30, 2023: member

Closing for now. If there is more information, or steps to reproduce, or something else, it can be reopened.

maflcko closed this on Nov 30, 2023

chenrui333 commented at 6:50 pm on November 30, 2023: none

So this is homebrew on Linux?

yeah, linuxbrew got merged into homebrew, so right now homebrew-core CI runs on both linux and macos

Please add exact steps to reproduce, otherwise little can be done here.

the reason why this does not happen for macos (I think) is due to the fact that we use system sqlite (uses_from_macos “sqlite”), which is using the old sqlite for macos builds.

I can run some local testing later and report it back.

jonatack commented at 10:24 pm on November 30, 2023: contributor

(FWIW, upgraded sqlite from 3.44.1 to 3.44.2. via homebrew, compiled and ran tests, and v25.1 and master are both green.)

fanquake commented at 12:50 pm on December 8, 2023: member

This is happening again in https://github.com/Homebrew/homebrew-core/pull/156745. i.e https://github.com/Homebrew/homebrew-core/actions/runs/7141174823/job/19448089734?pr=156745#step:4:47.

maflcko reopened this on Dec 8, 2023

maflcko commented at 1:12 pm on December 8, 2023: member

Again, it would be good to have steps to reproduce locally.

Also, double_serfloat_tests has nothing to do with sqlite. (You can compile them without wallet or sqlite)

fanquake renamed this:
~~bitcoin 25.1 regression test failure against sqlite 3.44.1~~
brew: serfloat_tests tests fail on Linux
on Dec 8, 2023

sipa commented at 6:36 pm on January 5, 2024: member

It appears that subnormal double values are converted to 0 for some reason. My guess would be that somehow std::fpclassify returns FP_ZERO for them, but I’m not sure it’s worth investigating.

These functions are only used to store fee estimate data on disk, since Bitcoin Core v22.0. We don’t care about subnormal numbers, I believe, and even then, this test is just verifying that the serialization is compatible with the pre-v22 code used on x86_64. I think we can just weaken the test to verify consistency of the encoding.

sipa commented at 8:06 pm on January 5, 2024: member

Can someone try if #29192 addresses this problem?

fanquake commented at 8:12 pm on January 5, 2024: member

I’ll push that branch into my downstream PR.

fanquake commented at 11:59 am on January 8, 2024: member

Again, it would be good to have steps to reproduce locally.

See #29192 (comment).

fanquake closed this on Mar 19, 2024

fanquake referenced this in commit 479ecc0515 on Mar 19, 2024

fanquake commented at 4:06 pm on June 5, 2024: member

Reopening as this is still failing, see: https://github.com/Homebrew/homebrew-core/pull/169269#issuecomment-2150438892.

Can be reproduced with:

 0docker pull docker.io/homebrew/brew:latest
 1docker run -it homebrew/brew
 2
 3brew install bitcoin --head --debug # ignore the 2 patch failures
 4brew test bitcoin
 5
 6/home/linuxbrew/.linuxbrew/Cellar/bitcoin/HEAD-ff7d205/bin/test_bitcoin
 7Running 610 test cases...
 8test/serfloat_tests.cpp(95): error: in "serfloat_tests/double_serfloat_tests": check TestDouble(std::numeric_limits<double>::denorm_min()) == 0x1 has failed [0 != 1]
 9test/serfloat_tests.cpp(96): error: in "serfloat_tests/double_serfloat_tests": check TestDouble(-std::numeric_limits<double>::denorm_min()) == 0x8000000000000001 has failed [9223372036854775808 != 9223372036854775809]
10
11*** 2 failures are detected in the test module "Bitcoin Core Test Suite"
12Error: bitcoin: failed

fanquake reopened this on Jun 5, 2024

brew: serfloat_tests tests fail on Linux #28941