ci: Use Ubuntu 24.04 Noble for asan,tsan,tidy,fuzz #28992

1. 
   maflcko commented at 8:47 am on December 4, 2023: member

   23.10 will be EOL mid next year, so a bump is needed before then for the master branch (and possibly the 26.x branch).

   Doing the bump now is fine, because the clang version is pinned to 17 inside the CI tasks. So a default clang version change in the system image should not affect the tasks. Once clang-18 is available and the default in April next year (https://discourse.ubuntu.com/t/noble-numbat-release-schedule/35649#planned-and-potentially-disruptive-archive-wide-activities-2), the pinned version could be bumped (for CI tasks that require a pin, like tidy), or the pin can be removed (for CI tasks that usually do not require a pin, like fuzz or the sanitizers).

2. ci: Use Ubuntu 24.04 Noble for tsan,tidy,fuzz fa83b65ef8
3. 
   DrahtBot commented at 8:47 am on December 4, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Dec 4, 2023
5. maflcko added the label Needs backport (26.x) on Dec 4, 2023
6. maflcko added this to the milestone 26.0 on Dec 4, 2023
7. maflcko removed this from the milestone 26.0 on Dec 4, 2023
8. maflcko added this to the milestone 26.1 on Dec 4, 2023
9. ci: Use Ubuntu 24.04 Noble for asan fad2392c58
10. maflcko renamed this:
    ci: Use Ubuntu 24.04 Noble for tsan,tidy,fuzz
    ci: Use Ubuntu 24.04 Noble for asan,tsan,tidy,fuzz
    on Dec 4, 2023
11. maflcko removed this from the milestone 26.1 on Dec 4, 2023
12. maflcko added this to the milestone 27.0 on Dec 4, 2023
13. DrahtBot added the label CI failed on Dec 4, 2023
14. DrahtBot removed the label CI failed on Dec 4, 2023
15. fanquake approved
16. 
    fanquake commented at 2:12 pm on December 6, 2023: member

    ACK fad2392c5861a88a87cb8a03d2fc9773e178feb8
17. fanquake merged this on Dec 6, 2023
18. fanquake closed this on Dec 6, 2023

    ---

19. fanquake referenced this in commit 153a0f8830 on Dec 6, 2023
20. fanquake referenced this in commit 8a5a6f641a on Dec 6, 2023
21. fanquake removed the label Needs backport (26.x) on Dec 6, 2023
22. 
    fanquake commented at 2:16 pm on December 6, 2023: member

    Will be backported in #29011.
23. maflcko deleted the branch on Dec 6, 2023
24. fanquake referenced this in commit f85f7e645f on Dec 8, 2023
25. fanquake referenced this in commit 1972a20e9b on Dec 8, 2023
26. 
    TheCharlatan commented at 10:26 pm on December 10, 2023: contributor

    When I apply this patch and run FILE_ENV="./ci/test/00_setup_env_native_tidy.sh" ./ci/test_run_all.sh, I get

     0131.2 CMake Error at /usr/lib/llvm-17/lib/cmake/clang/ClangTargets.cmake:833 (message):
     1131.2   The imported target "libclang" references the file
     2131.2 
     3131.2      "/usr/lib/llvm-17/lib/libclang-17.so.1"
     4131.2 
     5131.2   but this file does not exist.  Possible reasons include:
     6131.2 
     7131.2   * The file was deleted, renamed, or moved to another location.
     8131.2 
     9131.2   * An install or uninstall procedure did not complete successfully.
    10131.2 
    11131.2   * The installation package was faulty and contained
    12131.2 
    13131.2      "/usr/lib/llvm-17/lib/cmake/clang/ClangTargets.cmake"
    14131.2 
    15131.2   but not all the files it references.
    16131.2 
    17131.2 Call Stack (most recent call first):
    18131.2   /usr/lib/llvm-17/lib/cmake/clang/ClangConfig.cmake:20 (include)
    19131.2   CMakeLists.txt:20 (find_package)
    20131.2 
    21131.2 
    22131.2 -- Configuring incomplete, errors occurred!
    23------
    24test_imagefile:16
    25--------------------
    26  14 |     COPY ./ci/test/00_setup_env.sh ./${FILE_ENV} ./ci/test/01_base_install.sh /ci_container_base/ci/test/
    27  15 |     
    28  16 | >>> RUN ["bash", "-c", "cd /ci_container_base/ && set -o errexit && source ./ci/test/00_setup_env.sh && ./ci/test/01_base_install.sh"]
    29  17 |     
    30--------------------
    31ERROR: failed to solve: process "bash -c cd /ci_container_base/ && set -o errexit && source ./ci/test/00_setup_env.sh && ./ci/test/01_base_install.sh" did not complete successfully: exit code: 1
    

27. 
    fanquake commented at 9:36 am on December 11, 2023: member

    Looks like something similar (for LLVM 18) is being worked around upstream, by just creating the missing file: https://github.com/include-what-you-use/include-what-you-use/pull/1350.
28. 
    maflcko commented at 2:04 pm on December 12, 2023: member

    Will be fixed in 17.0.6-2 once noble-proposed is released, see https://bugs.launchpad.net/ubuntu/+source/llvm-toolchain-17/1%3A17.0.6-2/+publishinghistory
29. 
    fanquake commented at 9:35 am on December 13, 2023: member

    Will be fixed in 17.0.6-2 once noble-proposed is released,

    This has shipped, and 17.0.6-2 is available.

Contributors
maflcko DrahtBot fanquake TheCharlatan

Labels
Tests

Milestone
27.0