wallet: fix key parsing check for miniscript expressions #29027

1. 
   brunoerg commented at 10:10 am on December 8, 2023: contributor

   In ParseScript, when processing miniscript expressions, the way we check for key parsing error is wrong, the actual code is unreachable because we’re checking it into if (node) (successful parsing) statement.
2. wallet: fix key parsing check for miniscript expressions in `ParseScript` e1281f1bbd
3. 
   DrahtBot commented at 10:10 am on December 8, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sipa, RandyMcMillan, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #22838 (descriptors: Be able to specify change and receiving in a single descriptor string by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Wallet on Dec 8, 2023
5. fanquake requested review from darosior on Dec 8, 2023
6. fanquake requested review from achow101 on Dec 8, 2023
7. 
   sipa commented at 9:27 pm on December 20, 2023: member

   utACK e1281f1bbd884f15d40053c9bc24794d0ce9a58a
8. 
   RandyMcMillan commented at 10:07 pm on December 20, 2023: contributor

   utACK https://github.com/bitcoin/bitcoin/commit/e1281f1bbd884f15d40053c9bc24794d0ce9a58a
9. 
   achow101 commented at 4:57 pm on December 21, 2023: member

   ACK e1281f1bbd884f15d40053c9bc24794d0ce9a58a
10. DrahtBot removed review request from achow101 on Dec 21, 2023
11. achow101 merged this on Dec 21, 2023
12. achow101 closed this on Dec 21, 2023

    ---

Contributors
brunoerg DrahtBot sipa RandyMcMillan achow101

Review Requested
darosior

Labels
Wallet