In ParseScript, when processing miniscript expressions, the way we check for key parsing error is wrong, the actual code is unreachable because we're checking it into if (node) (successful parsing) statement.
wallet: fix key parsing check for miniscript expressions #29027
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2023-12-descriptor-fix-key-error changing 2 files +6 −6-
brunoerg commented at 10:10 AM on December 8, 2023: contributor
-
wallet: fix key parsing check for miniscript expressions in `ParseScript` e1281f1bbd
-
DrahtBot commented at 10:10 AM on December 8, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK sipa, RandyMcMillan, achow101 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #22838 (descriptors: Be able to specify change and receiving in a single descriptor string by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Wallet on Dec 8, 2023
- fanquake requested review from darosior on Dec 8, 2023
- fanquake requested review from achow101 on Dec 8, 2023
-
sipa commented at 9:27 PM on December 20, 2023: member
utACK e1281f1bbd884f15d40053c9bc24794d0ce9a58a
-
RandyMcMillan commented at 10:07 PM on December 20, 2023: contributor
-
achow101 commented at 4:57 PM on December 21, 2023: member
ACK e1281f1bbd884f15d40053c9bc24794d0ce9a58a
- DrahtBot removed review request from achow101 on Dec 21, 2023
- achow101 merged this on Dec 21, 2023
- achow101 closed this on Dec 21, 2023
- luke-jr referenced this in commit 75834cb808 on Apr 24, 2024
- bitcoin locked this on Dec 20, 2024
