test: fix `addnode` functional test failure on OpenBSD #29035

1. 
   theStack commented at 5:30 PM on December 8, 2023: contributor

   This is the functional test counterpart of PR #28891 / commit 007d6f0e85bc329040bb405ef6016339518caa66 (unfortunately, I missed it back then and only ran the unit tests -- sorry for the noise).

   master branch on OpenBSD 7.4:

   $ ./test/functional/rpc_net.py 
   2023-12-08T17:29:05.057000Z TestFramework (INFO): PRNG seed is: 6024296850131317403
   2023-12-08T17:29:05.058000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_au3zchif
   2023-12-08T17:29:05.618000Z TestFramework (INFO): Test getconnectioncount
   2023-12-08T17:29:05.618000Z TestFramework (INFO): Test getpeerinfo
   2023-12-08T17:29:06.643000Z TestFramework (INFO): Check getpeerinfo output before a version message was sent
   2023-12-08T17:29:06.709000Z TestFramework (INFO): Test getnettotals
   2023-12-08T17:29:06.773000Z TestFramework (INFO): Test getnetworkinfo
   2023-12-08T17:29:06.978000Z TestFramework (INFO): Test addnode and getaddednodeinfo
   2023-12-08T17:29:06.980000Z TestFramework (ERROR): Assertion failed
   Traceback (most recent call last):
     File "/home/thestack/bitcoin/test/functional/test_framework/test_framework.py", line 131, in main
       self.run_test()
     File "/home/thestack/bitcoin/./test/functional/rpc_net.py", line 65, in run_test
       self.test_addnode_getaddednodeinfo()
     File "/home/thestack/bitcoin/./test/functional/rpc_net.py", line 224, in test_addnode_getaddednodeinfo
       assert_raises_rpc_error(-23, "Node already added", self.nodes[0].addnode, node=ip_port2, command='add')
     File "/home/thestack/bitcoin/test/functional/test_framework/util.py", line 131, in assert_raises_rpc_error
       assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
   AssertionError: No exception raised
   

   On the PR branch, the same call succeeds.

2. test: fix `addnode` functional test failure on OpenBSD

   This is the functional test counterpart of PR #28891 /
   commit 007d6f0e85bc329040bb405ef6016339518caa66.

   fd0bde2793
3. 
   DrahtBot commented at 5:30 PM on December 8, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	kevkevinpal

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Dec 8, 2023
5. 
   kevkevinpal commented at 6:58 PM on December 8, 2023: contributor

   ACK fd0bde2

6. maflcko added this to the milestone 26.1 on Dec 9, 2023
7. maflcko removed this from the milestone 26.1 on Dec 9, 2023
8. 
   maflcko commented at 10:10 AM on December 9, 2023: member

   lgtm. Is the code in 26.x and does it need backport?

9. 
   theStack commented at 12:18 PM on December 9, 2023: contributor

   lgtm. Is the code in 26.x and does it need backport?

   No backport needed, the PR containing the code (#28155, commit 94e8882d820969ddc83f24f4cbe1515a886da4ea) was merged to master after 26.x branched off.

10. maflcko added this to the milestone 27.0 on Dec 9, 2023
11. fanquake merged this on Dec 11, 2023
12. fanquake closed this on Dec 11, 2023

    ---

13. theStack deleted the branch on Dec 11, 2023
14. bitcoin locked this on Dec 10, 2024

Milestone
27.0