doc/reduce-traffic: update/clarify max outbound connection count #29052

1. 
   MarnixCroes commented at 10:21 AM on December 11, 2023: contributor

   closes #29046

2. 
   DrahtBot commented at 10:21 AM on December 11, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	amitiuttarwar, brunoerg
   Stale ACK	mzumsande

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. 
   mzumsande commented at 4:35 PM on December 11, 2023: contributor

   Code Review ACK aa4907ae19c797493939dcbf4762cb1666f86546

4. doc: update/clarify max outbound connection count d58f89d355
5. in doc/reduce-traffic.md:9 in aa4907ae19 outdated

      8 | -Of the 10 outbound peers, there can be 8 full-relay connections and 2
      9 | -block-relay-only ones.
     10 | +By default, Bitcoin Core allows up to 125 connections to different peers, 11 of
     11 | +which are outbound. You can therefore, have at most 114 inbound connections.
     12 | +Of the 11 outbound peers, there can be 8 full-relay connections, 2
     13 | +block-relay-only ones and occasionally 1 short-lived feeler or an extra block-relay-only connection .
   

   ---

   ---

   

   brunoerg commented at 6:53 PM on December 11, 2023:

   nit:

   block-relay-only ones and occasionally 1 short-lived feeler or an extra block-relay-only connection.
   

   ---

   

   MarnixCroes commented at 7:06 PM on December 11, 2023:

   my bad, done

6. MarnixCroes force-pushed on Dec 11, 2023
7. 
   amitiuttarwar commented at 7:27 PM on December 11, 2023: contributor

   ACK d58f89d355faf46b68d0ff8095699d0aff41959c

8. DrahtBot requested review from mzumsande on Dec 11, 2023
9. brunoerg approved
10. 
    brunoerg commented at 10:56 AM on December 12, 2023: contributor

    ACK d58f89d355faf46b68d0ff8095699d0aff41959c

11. fanquake merged this on Dec 12, 2023
12. fanquake closed this on Dec 12, 2023

    ---

13. MarnixCroes deleted the branch on Dec 12, 2023
14. in doc/reduce-traffic.md:7 in d58f89d355

       2 | @@ -3,10 +3,10 @@ Reduce Traffic
       3 |  
       4 |  Some node operators need to deal with bandwidth caps imposed by their ISPs.
       5 |  
       6 | -By default, Bitcoin Core allows up to 125 connections to different peers, 10 of
       7 | -which are outbound. You can therefore, have at most 115 inbound connections.
       8 | -Of the 10 outbound peers, there can be 8 full-relay connections and 2
       9 | -block-relay-only ones.
      10 | +By default, Bitcoin Core allows up to 125 connections to different peers, 11 of
      11 | +which are outbound. You can therefore, have at most 114 inbound connections.
    

    ---

    ---

    

    jonatack commented at 10:21 PM on January 5, 2024:

    Perhaps just my read on this, but the following may have been clearer with respect to the inbound number also being the default setting only, and not an absolute limit.

    which are outbound and 114 are inbound.
    

15. 
    jonatack commented at 10:23 PM on January 5, 2024: member

    Post-merge review ACK with logging sanity check

    2024-01-05T21:54:39.437118Z [Init] m_max_automatic_connections: 125
    2024-01-05T21:54:39.437125Z [Init] m_max_outbound_full_relay: 8
    2024-01-05T21:54:39.437133Z [Init] m_max_outbound_block_relay: 2
    2024-01-05T21:54:39.437139Z [Init] m_max_automatic_outbound: 11
    2024-01-05T21:54:39.437145Z [Init] m_max_inbound: 114
    

16. bitcoin locked this on Jan 4, 2025

Contributors

MarnixCroesDrahtBotmzumsandebrunoergamitiuttarwarjonatack

Review Requested
mzumsande