Boost versions <1.73 have C++20-specific bugs that were fixed in the following commits:
I tested libboost1.71-dev in Ubuntu 20.04 and Boost 1.71, 1.72, 1.73 in our depends build system.
Closes #29063.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
https://github.com/boostorg/signals2/commit/15fcf213563718d2378b6b83a1614680a4fa8cec
This one could be fixed alternatively (in theory) by nuking signals2, but I don’t think this will happen any time soon.
Oops… Forgot to update a version in the AX_BOOST_BASE macro.
Fixed now.
Sorry.
Boost versions <1.73 have C++20-specific bugs that were fixed in the
following commits:
- https://github.com/boostorg/signals2/commit/15fcf213563718d2378b6b83a1614680a4fa8cec
- https://github.com/boostorg/test/commit/495c095dc063052ce54f2fe9217fe0fc69ced5f1
Should be fine to squash a 2-line diff into one commit?
Sure :)
This one could be fixed alternatively (in theory) by nuking signals2, but I don’t think this will happen any time soon.
I know a [WIP] branch for this “exists” in some form. cc @theuni
It’s not a WIP so much as a POC: https://github.com/theuni/bitcoin/commits/replace-boost-signals/
That implements the subset of signals that we rely on as a drop-in replacement. It passes tests and would serve as a good guide, but I don’t think that’s how we’d want to do it.
I could look at picking it up again and doing it right if there’s interest.