build: Bump g++ minimum supported version to 11 #29091

1. 
   maflcko commented at 12:07 pm on December 15, 2023: member

   This drops support for vanilla Ubuntu Focal 20.04 and Debian (Oldstable) Bullseye, compiling from source. Users on those operating systems would have to stick with a pre-compiled release, a previous release branch of Bitcoin Core, upgrade their system, compile their own compiler, or use a non-vanilla PPA or package manager.

   Otherwise, g++-11 is offered by common distributions:

   • https://packages.ubuntu.com/jammy/g++ (g++-11)
   • https://packages.debian.org/bookworm/g++ (g++-12)
   • FreeBSD 12/13 ships with g++ 12
   • CentOS-like 9 ships with g++ 11
   • OpenSuse Tumbleweed ships with g++ 13 https://software.opensuse.org/package/gcc13-c++ (No idea about OpenSuse Leap)
2. 
   DrahtBot commented at 12:07 pm on December 15, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	TheCharlatan, fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #29165 (build: Bump clang minimum supported version to 15 by maflcko)
   • #29077 ([WIP, DO NOT MERGE!!11111!!!!!] build: Require libc++-16 or later by maflcko)
   • #28687 (C++20 std::views::reverse by stickies-v)
   • #25972 (build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added this to the milestone 28.0 on Dec 15, 2023
4. DrahtBot added the label CI failed on Dec 25, 2023
5. DrahtBot removed the label CI failed on Dec 28, 2023
6. DrahtBot added the label Needs rebase on Jan 9, 2024
7. maflcko force-pushed on Jan 9, 2024
8. DrahtBot removed the label Needs rebase on Jan 9, 2024
9. maflcko force-pushed on Jan 12, 2024
10. 
    fanquake commented at 10:23 am on March 14, 2024: member

    Release compiler is now GC 12.x, so this should be possible.
11. maflcko force-pushed on Mar 14, 2024
12. build: Bump g++ minimum supported version to 11 fa8409e760
13. maflcko force-pushed on Mar 14, 2024
14. maflcko renamed this:
    [28.x] build: Bump g++ minimum supported version to 11
    build: Bump g++ minimum supported version to 11
    on Mar 14, 2024
15. DrahtBot added the label Build system on Mar 14, 2024
16. maflcko removed this from the milestone 28.0 on Mar 14, 2024
17. maflcko marked this as ready for review on Mar 14, 2024
18. 
    fanquake commented at 2:43 pm on March 14, 2024: member

    This drops support for vanilla Ubuntu Focal 20.04 and Debian (Oldstable) Bullseye.

    Just noting that this will only be support for vanilla compilation, our 28.x release binaries will continue to run on these platforms.

    Can we also drop this https://github.com/bitcoin/bitcoin/blob/3d255dfb67aede71ed39aaa54f4bcad550910cb7/src/util/fs_helpers.cpp#L257 if the minimum will be GCC 11.1.

19. Remove unused g++-10 workaround

    This reverts d4999d40b9bd04dc20111aaaa6ed2d3db1a5caf9

    fa5844f06d
20. 
    maflcko commented at 2:57 pm on March 14, 2024: member

    Thanks, edited OP and removed now unused code.
21. TheCharlatan approved
22. 
    TheCharlatan commented at 8:53 pm on March 15, 2024: contributor

    ACK fa5844f06d74b35cd27c1927e2250ebb494578e9
23. fanquake approved
24. 
    fanquake commented at 2:56 pm on March 18, 2024: member

    ACK fa5844f06d74b35cd27c1927e2250ebb494578e9
25. fanquake merged this on Mar 18, 2024
26. fanquake closed this on Mar 18, 2024

    ---

27. maflcko deleted the branch on Mar 18, 2024
28. 
    hebasto commented at 3:59 pm on March 18, 2024: member

    Post-merge ACK fa5844f06d74b35cd27c1927e2250ebb494578e9. Glad to see that the Windows-specific workaround is gone.
29. hebasto referenced this in commit e8bbd04396 on Mar 23, 2024
30. fanquake referenced this in commit 71c51c161d on Apr 4, 2024
31. hebasto referenced this in commit 475cf6dcad on Apr 12, 2024
32. hebasto referenced this in commit bdaa036ca4 on Apr 16, 2024
33. fanquake referenced this in commit a786fd2041 on May 21, 2024
34. 
    fanquake commented at 1:27 pm on June 10, 2024: member

    Release note in #30261.

Contributors
maflcko DrahtBot fanquake TheCharlatan hebasto

Labels
Build system