Currently tidy errors are not nice, because the user may have to scroll up to see them in a large block of text. See for example (before) https://github.com/bitcoin/bitcoin/runs/19670551485
Fix that by teeing the output to a file and summarizing the errors in the end again. See for example (after): https://github.com/bitcoin/bitcoin/runs/22647850662
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | hebasto, TheCharlatan |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--2e250dc3d92b2c9115b66051148d6e47-->
🤔 There hasn't been much activity lately and the CI seems to be failing.
If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.
Fixed the bash logic, rebased, and updated OP
ACK fae70ba00da27ca5734c88e9964c872c7faa0f78, logs with errors look cleaner.
181 | @@ -182,7 +182,11 @@ if [ "${RUN_TIDY}" = "true" ]; then 182 | 183 | set -eo pipefail 184 | cd "${BASE_BUILD_DIR}/bitcoin-$HOST/src/" 185 | - ( run-clang-tidy-"${TIDY_LLVM_V}" -quiet -load="/tidy-build/libbitcoin-tidy.so" "${MAKEJOBS}" ) | grep -C5 "error" 186 | + if ! ( run-clang-tidy-"${TIDY_LLVM_V}" -quiet -load="/tidy-build/libbitcoin-tidy.so" "${MAKEJOBS}" | tee tmp.tidy-out.txt ); then 187 | + grep -C5 "error: " tmp.tidy-out.txt
Could use grep -B 1 -A 5 instead?
I think it will always be a guess at the context. I think longer error messages than 5 lines are possible, so if someone needs the full context, they'll have to scroll up either way.
rfm? Or does it need more ACKs, or does it need something else?
ACK fae70ba00da27ca5734c88e9964c872c7faa0f78