Performance optimization for bloom filters. #2914

pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:bloom_faster changing 4 files +33 −7

gmaxwell commented at 9:03 AM on August 20, 2013: contributor

This reduces a peer's ability to attack network resources by using a full bloom filter, but without reducing the usability of bloom filters. It sets a default match everything filter for peers and it generalizes a prior optimization to cover more cases.
gmaxwell commented at 9:04 AM on August 20, 2013: contributor

Tested multibit and full node sync as well as a number of hours of regular network operation. More testing with spv nodes would be helpful.
mikehearn commented at 9:04 AM on August 20, 2013: contributor

Code looks good to me. I haven't tested it in practice yet.
sipa commented at 9:21 AM on August 20, 2013: member

Looks good in general to me, but go fix the tests :)

Performance optimization for bloom filters.

This reduces a peer's ability to attack network resources by
 using a full bloom filter, but without reducing the usability
 of bloom filters.  It sets a default match everything filter
 for peers and it generalizes a prior optimization to
 cover more cases.

37c6389c5a

gmaxwell commented at 9:29 AM on August 20, 2013: contributor

@sipa ::nods:: As you wish. :) (where is my brown paper bag?)
BitcoinPullTester commented at 10:17 AM on August 20, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/37c6389c5a0ca63ae3573440ecdfe95d28ad8f07 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
wtogami commented at 8:55 PM on August 20, 2013: contributor

FWIW, to help with sanity testing, Litecoin deployed this in testing on nodes with hundreds of of peer connections, both with and without bloom enabled.
gavinandresen commented at 10:45 PM on August 20, 2013: contributor

ACK, ran this overnight on my Mac with no drama.
gavinandresen referenced this in commit 5250fdcc6c on Aug 20, 2013
gavinandresen merged this on Aug 20, 2013
gavinandresen closed this on Aug 20, 2013
IntegralTeam referenced this in commit 240238b190 on Jun 4, 2019
DrahtBot locked this on Sep 8, 2021

Contributors