Built on top of #2905 (getwork removal), intended to complement #2901 (walletless node).
Remove embedded CPU miner and eliminate wallet dependency for getblocktemplate #2917
pull luke-jr wants to merge 4 commits into bitcoin:master from luke-jr:rm_miner changing 14 files +16 −658-
luke-jr commented at 1:24 PM on August 20, 2013: member
-
9e037c2700
RPC: Remove 'getwork' deprecated mining protocol
Use getblocktemplate instead.
-
Remove mentions of 4way miner in debian bitcoin.conf example/manpage e527bab9e8
-
Remove embedded BitcoinMiner 8dfdc25ed5
-
CreateNewBlock: Remove CReserveKey dependency dcc1891c3b
-
BitcoinPullTester commented at 3:36 AM on August 21, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/dcc1891c3b2bcecd1211b6b899696ae1e5e30aca for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
Diapolo commented at 10:36 AM on August 21, 2013: none
NACK, as the internal miner is of great use in testnet.
-
luke-jr commented at 11:37 AM on August 21, 2013: member
You can just as well use a normal miner for testnet, which reduces the differences from mainnet and probably finds blocks faster too.
-
wtogami commented at 2:24 AM on August 22, 2013: contributor
If pooler's CPU minerd grows GBT support, and both it and bfgminer and reads bitcoin.conf to find the RPC auth mining details, then the lazy should have no problem with the testnet use case.
-
laanwj commented at 5:39 AM on August 22, 2013: member
I've never used the internal miner, not even on testnet.
It would be nice to still have a simple CPU miner in the bitcoin repository somewhere as example and for testnet, but I very much agree with removing it from the main executable.
-
gmaxwell commented at 8:01 AM on August 22, 2013: contributor
I'm in favor of this, even as a test the integrated one is not good because its ~entirely different code than anyone uses to mine the mainnet, and IIRC has previously had different bugs. I also however, strongly feel that we should also package a usable miner, because thats part of a complete network node... and its needed for testnet in any case. But it could be, and I think should be, a separate executable that uses the GBT RPC like all miners use these days.
-
gavinandresen commented at 9:13 PM on August 22, 2013: contributor
NACK from me on removing the internal miner. I use it all the time to test stuff.
-
gmaxwell commented at 12:48 AM on August 24, 2013: contributor
If someone really wants to keep it, I see no enormous gain in removing it either. Though if this is closed, please split the wallet dependency removal. I think we do want that regardless.
-
- jgarzik closed this on Aug 25, 2013
- Bushstar referenced this in commit a6eee07f29 on Apr 8, 2020
- DrahtBot locked this on Sep 8, 2021
