build: Fix -Xclang -internal-isystem option #29195

1. 
   hebasto commented at 11:40 am on January 7, 2024: member

   This PR:

   • addresses #29165 (review)
   • fixes https://github.com/bitcoin/bitcoin/issues/29174
2. build: Fix `-Xclang -internal-isystem` option

   LLVM Clang >=16.0 and Apple Clang >=15.0 do not recognize
   `-Xclang -internal-isystem/usr/local/include` anymore.
   
   For example, see: https://github.com/llvm/llvm-project/commit/cbbe1d44546db52c71c9a2b18f85b87ae82df9e7

   8decc5c726
3. 
   DrahtBot commented at 11:40 am on January 7, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #29165 (build: Bump clang minimum supported version to 15 by maflcko)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Tests on Jan 7, 2024
5. 
   hebasto commented at 11:48 am on January 7, 2024: member

   https://github.com/bitcoin/bitcoin/actions/runs/7437962301/job/20236177232:

   0checking whether C++ preprocessor accepts -Xclang -internal-isystem -Xclang /usr/local/include/... yes
   

6. hebasto added the label macOS on Jan 7, 2024
7. hebasto added the label Build system on Jan 7, 2024
8. maflcko removed the label Tests on Jan 8, 2024
9. 
   maflcko commented at 10:22 am on January 8, 2024: member

   pull title should be “build: Fix -Xclang -internal-isystem option”? Otherwise lgtm
10. hebasto renamed this:
    ci: Switch native macOS CI job to Xcode 15.0
    build: Fix -Xclang -internal-isystem option
    on Jan 8, 2024
11. hebasto renamed this:
    build: Fix -Xclang -internal-isystem option
    build: Fix `-Xclang -internal-isystem` option
    on Jan 8, 2024
12. 
    hebasto commented at 10:23 am on January 8, 2024: member

    pull title should be “build: Fix -Xclang -internal-isystem option”? Otherwise lgtm

    Done.

13. 
    fanquake commented at 10:28 am on January 8, 2024: member

    The same Xcode version is used for the release binaries.

    Can probably drop this, or be more specific, because we don’t use Xcode to build release binaries (only the SDK, which is versioned differently).

14. ci: Switch native macOS CI job to Xcode 15.0 d742be3d3f
15. hebasto force-pushed on Jan 8, 2024
16. 
    hebasto commented at 10:31 am on January 8, 2024: member

    The same Xcode version is used for the release binaries.

    Can probably drop this, or be more specific, because we don’t use Xcode to build release binaries (only the SDK, which is versioned differently).

    Dropped.

17. fanquake approved
18. 
    fanquake commented at 10:33 am on January 9, 2024: member

    ACK d742be3d3f5d5063d7160f72422bce2fec953f38. The same as what was done in #27328.

    For example, see: https://github.com/llvm/llvm-project/commit/cbbe1d44546db52c71c9a2b18f85b87ae82df9e7

    I guess this is meant to be an example of someone else using -Xclang? However this commit is from > 10 years ago, and isn’t related to, or an explanation for the recent change in Clang behaviour.

19. 
    hebasto commented at 10:36 am on January 9, 2024: member

    I guess this is meant to be an example of someone else using -Xclang?

    Right, just an example. I forgot about #27328.

20. fanquake merged this on Jan 9, 2024
21. fanquake closed this on Jan 9, 2024

    ---

22. hebasto deleted the branch on Jan 9, 2024

Contributors
hebasto DrahtBot maflcko fanquake

Labels
macOS Build system