Time of comparison proportional length of shorter argument. Less operations on cycle. (Removing weight % operation).
google translate: The comparison is proportional to the shortest argument. Removed an expensive operation "modulo" of the cycle.
Optimization TimingResistantEqual #2920
pull Enelar wants to merge 2 commits into bitcoin:master from Enelar:master changing 1 files +27 −15-
Enelar commented at 4:43 AM on August 21, 2013: none
-
1621da0459
Optimization TimingResistantEqual
Time of comparison proportional length of shorter argument. Less operations on cycle. (Removing weight % operation).
-
328433fbd5
Speedup CMedianFilter
By the defer `rendering` of sorted values we gaining speed on multiply numbers insert.
-
BitcoinPullTester commented at 6:06 AM on August 21, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/328433fbd5be0276da03a5199afc39ed5264c5e9 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
gmaxwell commented at 7:13 PM on August 21, 2013: contributor
Thanks for taking the time to try out something here, but I'm going to have to decline this optimization. The timing resistant equal is used to avoid leaking information about the length of RPC passwords in timing, your optimization would restore that information leak.
If you're interested in working on improving performance, I suggest doing some profiling on Bitcoin and working on things that show up high in the profile.
- gmaxwell closed this on Aug 21, 2013
- IntegralTeam referenced this in commit 394bec4838 on Jun 4, 2019
- DrahtBot locked this on Sep 8, 2021
Contributors