Using emplace_back and disabling the modernize-use-emplace Tidy CI check seems pointless here, as IIUC it doesn't avoid a temporary object compared to just using push_back. See #28583 for more context.
refactor: use push_back in TaprootBuilder::Add(), rm NOLINTNEXTLINE and comment #29202
pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:2024-01-rm-unneeded-NOLINTNEXTLINE changing 1 files +1 −3-
jonatack commented at 2:41 AM on January 8, 2024: member
-
DrahtBot commented at 2:41 AM on January 8, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
- DrahtBot added the label CI failed on Jan 8, 2024
-
9d4893b863
refactor: use push_back in TaprootBuilder::Add(), rm NOLINTNEXTLINE and comment
`emplace_back` seems pointless here, as it doesn't avoid a temporary object compared to `push_back`
- jonatack renamed this:
Remove no-longer-needed NOLINTNEXTLINE since C++20 upgrade
refactor: use push_back in TaprootBuilder::Add(), rm NOLINTNEXTLINE and comment
on Jan 8, 2024 - jonatack force-pushed on Jan 8, 2024
- jonatack closed this on Jan 8, 2024
- jonatack deleted the branch on Jan 12, 2024
- bitcoin locked this on Jan 11, 2025
Labels