build: Drop ALLOW_HOST_PACKAGES support in depends #29203

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240108-allow changing 4 files +3 −9
  1. hebasto commented at 3:02 pm on January 8, 2024: member

    The ALLOW_HOST_PACKAGES variable was introduced in bitcoin#10508 “to speed up build and avoid timeout”.

    It is no longer the case for our CI infrastructure, which uses self- hosted persistent workers and depends caching.

    In the current circumstances, it does not seem worth porting this feature to the upcoming CMake-based build system.

  2. DrahtBot commented at 3:02 pm on January 8, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake, TheCharlatan
    Concept ACK theuni

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #29091 ([28.x] build: Bump g++ minimum supported version to 11 by maflcko)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. DrahtBot added the label Build system on Jan 8, 2024
  4. build: Drop `ALLOW_HOST_PACKAGES` support in depends
    The `ALLOW_HOST_PACKAGES` variable was introduced in bitcoin#10508 "to
    speed up build and avoid timeout".
    
    It is no longer the case for our CI infrastructure, which uses self-
    hosted persistent workers and depends caching.
    
    In the current circumstances, it does not seem worth porting this
    feature to the upcoming CMake-based build system.
    080763a058
  5. in ci/test/00_setup_env_native_qt5.sh:12 in e3627ca114 outdated
     9@@ -10,7 +10,7 @@ export CONTAINER_NAME=ci_native_qt5
    10 export CI_IMAGE_NAME_TAG="docker.io/debian:bullseye"
    11 # Use minimum supported python3.9 and gcc-10, see doc/dependencies.md
    12 export PACKAGES="gcc-10 g++-10 python3-zmq qtbase5-dev qttools5-dev-tools libdbus-1-dev libharfbuzz-dev"
    


    maflcko commented at 3:54 pm on January 8, 2024:
    0export PACKAGES="gcc-10 g++-10 python3-zmq"
    

    hebasto commented at 3:57 pm on January 8, 2024:
    Thanks! Fixed.
  6. hebasto force-pushed on Jan 8, 2024
  7. fanquake commented at 10:52 am on January 9, 2024: member
    ACK 080763a058f399583deb9dea6687e87fc1c097a9 - I can’t imagine this option got any use outside our CI. It’s also mostly just at odds with the idea of a self-contained dependency builder.
  8. theuni commented at 10:53 am on January 9, 2024: member
    Concept ACK. Happy to have this gone.
  9. TheCharlatan approved
  10. TheCharlatan commented at 10:57 am on January 9, 2024: contributor
    ACK 080763a058f399583deb9dea6687e87fc1c097a9
  11. DrahtBot requested review from theuni on Jan 9, 2024
  12. fanquake merged this on Jan 9, 2024
  13. fanquake closed this on Jan 9, 2024

  14. hebasto deleted the branch on Jan 9, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-22 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me