This PR adds 64 bit arithmetic op codes to the Script interpreter.
This PR corresponds with this BIP proposal: https://github.com/bitcoin/bips/pull/1538
This work is heavily borrowed from the elements implementation of 64 bit op codes: https://github.com/ElementsProject/elements/pull/1020
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Concept ACK | moonsettler, tiero, hsjoberg |
If your review is incorrectly listed, please react with š to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
leaf_version parameter to taproot_tree_helper() by Christewart)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
š§ At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.
Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
Leave a comment here, if you need help tracking down a confusing failure.
š§ At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.
Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
Leave a comment here, if you need help tracking down a confusing failure.
Rework IsOpSuccess() to use SigVersion rather than leaf_version
Use switch based impl for IsOpSuccess()
Remove default in switch statement
Fix compiler warning
Move SigVersion to sigversion.h
Fix includes
try to fix compile
Add sigversion.h
Add include guards
Remove liquid args
WIP
Get simple OP_1 functional test case working
Get tests for arithmetic and comparison opcodes working
Get all functional tests passing
Rename test case to Arithmetic64bitTest
Rename file to feature_64bit_arithmetic_opcodes.py, add it to test_runner.py
Get tests passing in feature_taproot.py
Remove unused push_le4
Revert test fixture setup
Cleanup
Fix linting
test: Add leaf_version parameter to taproot_tree_helper()
Fix bug
Fix bugs
Fix compile
Fix missing sigversion checks
Fix htole64 -> htole64_internal due to #29263
Add negative test case for OP_LE64TOSCRIPTNUM
Use OP_EQUAL rather than OP_EQUALVERIFY
Fix rebase
š This pull request conflicts with the target branch and needs rebase.