wallet: Refactor DumpWallet function to accept -dumpfile path argument #29223

1. 
   BrandonOdiwuor commented at 9:19 am on January 11, 2024: contributor

   Quick follow-up to #29117, coming from https://github.com/bitcoin/bitcoin/pull/29117#discussion_r1431999422.

   Refactor DumpWallet(...) to accept the -dumpfile path arg instead of the entire ArgsManager

2. wallet: Refactor DumpWallet function to accept -dumpfile path argument cd8b3ba552
3. 
   DrahtBot commented at 9:19 am on January 11, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label Wallet on Jan 11, 2024
5. 
   maflcko commented at 9:36 am on January 11, 2024: member

   Not sure. The current version seems just fine
6. 
   furszy commented at 1:36 pm on January 11, 2024: member

   The rationale behind this was to remove the <common/args.h> include from dump.cpp and the ArgsManager type from dump.h (which are missing here). Also, should pass fs::path instead of a string.

   This cleans up code but.. it was a tiny nit that I would group with other changes. Making tiny refactoring PRs like this isn’t really the best (we could have dozens of it meanwhile we only have a handful amount of reviewers).

7. BrandonOdiwuor closed this on Jan 14, 2024

   ---

Contributors
BrandonOdiwuor DrahtBot maflcko furszy

Labels
Wallet