Quick follow-up to #29117, coming from https://github.com/bitcoin/bitcoin/pull/29117#discussion_r1431999422.
Refactor DumpWallet(...) to accept the -dumpfile path arg instead of the entire ArgsManager
wallet: Refactor DumpWallet function to accept -dumpfile path argument #29223
pull BrandonOdiwuor wants to merge 1 commits into bitcoin:master from BrandonOdiwuor:dumpwallet-refactor changing 3 files +4 −4-
BrandonOdiwuor commented at 9:19 AM on January 11, 2024: contributor
-
wallet: Refactor DumpWallet function to accept -dumpfile path argument cd8b3ba552
-
DrahtBot commented at 9:19 AM on January 11, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
- DrahtBot added the label Wallet on Jan 11, 2024
-
maflcko commented at 9:36 AM on January 11, 2024: member
Not sure. The current version seems just fine
-
furszy commented at 1:36 PM on January 11, 2024: member
The rationale behind this was to remove the
<common/args.h>include from dump.cpp and theArgsManagertype fromdump.h(which are missing here). Also, should passfs::pathinstead of a string.This cleans up code but.. it was a tiny nit that I would group with other changes. Making tiny refactoring PRs like this isn't really the best (we could have dozens of it meanwhile we only have a handful amount of reviewers).
- BrandonOdiwuor closed this on Jan 14, 2024
- bitcoin locked this on Jan 13, 2025
Contributors
Labels