Revert "build: Fix regression in "ARMv8 CRC32 intrinsics" test" #29226

pull dergoegge wants to merge 1 commits into bitcoin:master from dergoegge:2024-01-revert-228d6a29 changing 1 files +3 −1
  1. dergoegge commented at 11:36 AM on January 11, 2024: member

    This reverts commit 228d6a2969e4fcee573c9df7aad31550eab9c8d4.

    Fixes #29178

  2. DrahtBot commented at 11:36 AM on January 11, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  3. dergoegge commented at 11:37 AM on January 11, 2024: member

    We could alternatively add a suppression but I prefer reverting unless someone can explain how this is not an actual bug.

  4. dergoegge commented at 11:59 AM on January 11, 2024: member
  5. hebasto commented at 12:08 PM on January 14, 2024: member

    We could alternatively add a suppression but I prefer reverting unless someone can explain how this is not an actual bug.

    Assuming that this is a bug, disabling the buggy feature should be documented properly, no?

  6. hebasto commented at 8:29 PM on January 14, 2024: member

    An alternative approach suggested in https://github.com/bitcoin-core/crc32c-subtree/pull/6.

  7. DrahtBot added the label CI failed on Jan 15, 2024
  8. Revert "build: Fix regression in "ARMv8 CRC32 intrinsics" test"
    This reverts commit 228d6a2969e4fcee573c9df7aad31550eab9c8d4.
    273663fbb5
  9. dergoegge force-pushed on Jan 18, 2024
  10. dergoegge commented at 2:54 PM on January 18, 2024: member

    Added documentation about the potential bug

  11. DrahtBot removed the label CI failed on Jan 18, 2024
  12. willcl-ark added the label Build system on Jan 24, 2024
  13. dergoegge closed this on Jan 26, 2024

  14. bitcoin locked this on Jan 25, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me