depends: Allow PATH with spaces in directory names. #29237

pull alfonsoromanz wants to merge 1 commits into bitcoin:master from alfonsoromanz:allow-spaces-for-paths-in-depends changing 2 files +4 −4

alfonsoromanz commented at 6:47 PM on January 11, 2024: contributor

The goal of this PR is to help close #28733. I reverted the change on depends/config.guess based on the feedback provided in the previous PR. I've also incorporated the test mentioned by maflcko
[depends] Allow PATH with spaces in directory names.
added test and update code based on feedback
4756114e50
DrahtBot commented at 6:47 PM on January 11, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko, hebasto, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
maflcko commented at 7:00 PM on January 11, 2024: member

lgtm ACK 4756114e505cff8848fb6344ef9a48d8822066c1

Thank you!
maflcko added the label Build system on Jan 11, 2024
fanquake renamed this:
~~[depends] Allow PATH with spaces in directory names.~~
depends: Allow PATH with spaces in directory names.
on Jan 12, 2024
maflcko added the label DrahtBot Guix build requested on Jan 12, 2024

Type	Reviewers
ACK	maflcko, hebasto, TheCharlatan

DrahtBot commented at 1:52 AM on January 13, 2024: contributor

Guix builds (on x86_64)

File	commit 3ba8de1b704d590fa4e1975620bd21d830d11666<br>(master)	commit a53cb9ef3eae332d0e60e73d02e6ca7c6b846924<br>(master and this pull)
SHA256SUMS.part	`6a26ff1faac7dd15...`	`d1d804ef096b8fac...`
*-aarch64-linux-gnu-debug.tar.gz	`a8f1a939191715ff...`	`914cba1cf48a9aa1...`
*-aarch64-linux-gnu.tar.gz	`8baec64c5f137b7e...`	`00d27e5e2fc6f708...`
*-arm-linux-gnueabihf-debug.tar.gz	`6c378e44f04d9c82...`	`779bf69ebd35116b...`
*-arm-linux-gnueabihf.tar.gz	`2746e7a258c24d0e...`	`117a0712043c64cc...`
*-arm64-apple-darwin-unsigned.tar.gz	`09a4a03ddf31c8a2...`	`900dbda2652ed156...`
*-arm64-apple-darwin-unsigned.zip	`f06f0f8158bd13b3...`	`dd51aac3474d0c7c...`
*-arm64-apple-darwin.tar.gz	`e218a53b38f7267a...`	`22c941fb327be30b...`
*-powerpc64-linux-gnu-debug.tar.gz	`1855330fa6ab5cab...`	`ae79ad9159f95c6a...`
*-powerpc64-linux-gnu.tar.gz	`8d3090ca3af83763...`	`0c0b3c1e9e9298d1...`
*-powerpc64le-linux-gnu-debug.tar.gz	`ed05efc2f85d122e...`	`51d90458808a5637...`
*-powerpc64le-linux-gnu.tar.gz	`ecf3cd0aa490aa2c...`	`b86525b093f5aa21...`
*-riscv64-linux-gnu-debug.tar.gz	`4d22d7bdf2cf1c39...`	`c0ef015a8c845767...`
*-riscv64-linux-gnu.tar.gz	`bc514eefa405e70a...`	`c2a6fde8aaaebd1d...`
*-x86_64-apple-darwin-unsigned.tar.gz	`6cc91065bef81e4a...`	`dfaecd8041630e6e...`
*-x86_64-apple-darwin-unsigned.zip	`aae439a850c07feb...`	`63787a345342153c...`
*-x86_64-apple-darwin.tar.gz	`a6e97b1ea862cb92...`	`bfbcac2aac705ff0...`
*-x86_64-linux-gnu-debug.tar.gz	`f4211b34c928d9c5...`	`c46aa77fe0f04f75...`
*-x86_64-linux-gnu.tar.gz	`56f976b611aca8a0...`	`34f26bff20f5a275...`
*.tar.gz	`d2e0c2fb5ecf6cca...`	`10f3a3d34a4a7e9b...`
guix_build.log	`8ad50c48f3c2c87d...`	`aec5a0bdfe359788...`
guix_build.log.diff		`a3e94ee06c841237...`

DrahtBot removed the label DrahtBot Guix build requested on Jan 13, 2024
hebasto approved
hebasto commented at 10:20 AM on January 13, 2024: member

ACK 4756114e505cff8848fb6344ef9a48d8822066c1, successfully built depends on Ubuntu 22.04.
TheCharlatan approved
TheCharlatan commented at 12:09 PM on January 13, 2024: contributor

ACK 4756114e505cff8848fb6344ef9a48d8822066c1
DrahtBot added the label CI failed on Jan 15, 2024
fanquake merged this on Jan 15, 2024
fanquake closed this on Jan 15, 2024
Retropex referenced this in commit 58a667b9dc on Mar 28, 2024
bitcoin locked this on Jan 14, 2025