rpc: Fix race in loadtxoutset #29262

1. 
   maflcko commented at 3:49 pm on January 17, 2024: member

   The tip may have advanced, also if it did not, there is no reason to have two variables point to the same block.

   Fixes #27596 (review)

2. rpc: Fix race in loadtxoutset

   The tip may have advanced, also if it did not, there is no reason to
   have two variables point to the same block.

   fa9108941f
3. test: Use blocks_path where possible 5555d8db33
4. 
   DrahtBot commented at 3:49 pm on January 17, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	pablomartin4btc, BrandonOdiwuor, achow101
   Approach ACK	jamesob

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. DrahtBot renamed this:
   rpc: Fix race in loadtxoutset
   rpc: Fix race in loadtxoutset
   on Jan 17, 2024
6. DrahtBot added the label RPC/REST/ZMQ on Jan 17, 2024
7. 
   jamesob commented at 4:23 pm on January 17, 2024: member

   Approach ACK, thanks.
8. 
   pablomartin4btc commented at 6:57 pm on January 17, 2024: member

   ACK 5555d8db3313f893609eb0cf549bb597361d4466
9. DrahtBot requested review from jamesob on Jan 17, 2024
10. BrandonOdiwuor approved
11. 
    BrandonOdiwuor commented at 1:40 pm on January 18, 2024: contributor

    Code Review ACK 5555d8db3313f893609eb0cf549bb597361d4466
12. 
    achow101 commented at 6:03 pm on January 18, 2024: member

    Should this be backported?
13. 
    achow101 commented at 6:05 pm on January 18, 2024: member

    ACK 5555d8db3313f893609eb0cf549bb597361d4466
14. 
    maflcko commented at 6:06 pm on January 18, 2024: member

    Should this be backported?

    I don’t think assumeutxo params were specified for the main chain, and a wrong RPC result output in some test cases seems harmless.

15. achow101 merged this on Jan 18, 2024
16. achow101 closed this on Jan 18, 2024

    ---

17. maflcko deleted the branch on Jan 18, 2024

Contributors
maflcko DrahtBot jamesob pablomartin4btc BrandonOdiwuor achow101

Review Requested
jamesob

Labels
RPC/REST/ZMQ