test: fix wallet_import_rescan unrounded minimum amount #29343

pull stickies-v wants to merge 1 commits into bitcoin:master from stickies-v:2024-01/fix-walletimportrescan-invalid changing 1 files +5 −3
  1. stickies-v commented at 10:46 AM on January 29, 2024: contributor

    Addresses #29283 (review).

    Fixes a JSONRPCException: Invalid amount (-3) exception by ensuring the amount sent to sendtoaddress is rounded to 8 decimals.

    See https://cirrus-ci.com/task/5562947183837184?logs=ci#L2559

    Note: since round can also round down, min_amount is not exactly guaranteed, but this is not a problem for the current usage. I've added a docstring to highlight this.

  2. test: fix wallet_import_rescan unrounded minimum amount
    Fixes a `JSONRPCException: Invalid amount (-3)` exception by
    ensuring the amount sent to `sendtoaddress` is rounded to 8
    decimals.
    
    See https://cirrus-ci.com/task/5562947183837184?logs=ci#L2559
    26ad2aeb29
  3. DrahtBot commented at 10:46 AM on January 29, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK sr-gi

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Jan 29, 2024
  5. maflcko added this to the milestone 27.0 on Jan 29, 2024
  6. sr-gi commented at 9:19 PM on January 30, 2024: member

    ACK 26ad2ae

    I found this and got to a similar patch independently

  7. maflcko approved
  8. maflcko commented at 8:48 AM on January 31, 2024: member

    lgtm

  9. fanquake merged this on Jan 31, 2024
  10. fanquake closed this on Jan 31, 2024

  11. bitcoin locked this on Jan 30, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me