test: fixes flaky wallet_import_rescan functional test #29350

pull sr-gi wants to merge 1 commits into bitcoin:master from sr-gi:2024-01-legacy-wallet-test changing 1 files +2 −1
  1. sr-gi commented at 8:38 PM on January 30, 2024: member

    wallet_import_rescan is, potentially, not rounding values used for sendtoaddress in one of the test cases. Under normal conditions, the value is randomly picked and rounded to 8 decimal positions, however, for this specific case the value is limited to a maximum value that is not properly rounded. If that value happens to be picked, the test will fail.

    I noticed this in a completely unrelated PR where the test failed: https://cirrus-ci.com/task/5467779164274688?logs=ci#L2684

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. test: fixes flaky wallet_import_rescan functional test
    wallet_import_rescan is, potentially, not rounding values used for `sendtoaddress`
    in one of the tests cases. Under normal conditions, the value is randomly picked and rounded
    to 8 decimal positions, however, for this specific case the value is limited to a maximum value that
    is not properly rounded. If that value happens to be picked, the test will fail.
    bb5ffa05e4
  3. DrahtBot commented at 8:38 PM on January 30, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. DrahtBot added the label Tests on Jan 30, 2024
  5. in test/functional/wallet_import_rescan.py:150 in bb5ffa05e4
     146 | @@ -147,6 +147,7 @@ def check(self, txid=None, amount=None, confirmation_height=None):
     147 |  
     148 |  def get_rand_amount():
     149 |      r = random.uniform(AMOUNT_DUST, 1)
     150 | +    r = AMOUNT_DUST
    


    furszy commented at 9:01 PM on January 30, 2024:

    you are overwriting the random number.


    sr-gi commented at 9:04 PM on January 30, 2024:

    Oh wait, that was me debugging, my bad

  6. furszy commented at 9:01 PM on January 30, 2024: member

    See #29343.

  7. sr-gi commented at 9:06 PM on January 30, 2024: member

    See #29343.

    Ups, I missed that. Closing

  8. sr-gi closed this on Jan 30, 2024

  9. bitcoin deleted a comment on Jan 30, 2024
  10. bitcoin locked this on Jan 29, 2025
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me