wallet: remove unused 'accept_no_keys' arg from decryption process #29375

pull furszy wants to merge 1 commits into bitcoin:master from furszy:2024_wallet_saturday_garbage_collector changing 5 files +13 −14

furszy commented at 4:06 PM on February 3, 2024: member

Found it while reviewing other PR. Couldn't contain myself from cleaning it up.

The wallet decryption process (CheckDecryptionKey() and Unlock()) contains an arg 'accept_no_keys,' introduced in #13926, that has never been used. Additionally, this also removes the unimplemented SplitWalletPath function.

wallet: remove unused 'accept_no_keys' arg from decryption process

The wallet decryption process (CheckDecryptionKey() and Unlock())
contains an arg 'accept_no_keys,' introduced in #13926, that has
never been used.
Additionally, this also removes the unimplemented SplitWalletPath
function.

2bb25ce502

DrahtBot commented at 4:06 PM on February 3, 2024: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK delta1, epiccurious, theStack, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #28710 (Remove the legacy wallet and BDB dependency by achow101)
- #26606 (wallet: Implement independent BDB parser by achow101)
- #26596 (wallet: Migrate legacy wallets to descriptor wallets without requiring BDB by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label Wallet on Feb 3, 2024
delta1 commented at 5:52 PM on February 4, 2024: none

ACK 2bb25ce5023c4d56c8b11e9c75f9f8bd69894452

Nice cleanup.
epiccurious commented at 3:58 PM on February 6, 2024: contributor

utACK 2bb25ce5023c4d56c8b11e9c75f9f8bd69894452.
theStack approved
theStack commented at 4:22 PM on February 6, 2024: contributor

Code-review ACK 2bb25ce5023c4d56c8b11e9c75f9f8bd69894452
achow101 commented at 5:53 PM on February 6, 2024: member

ACK 2bb25ce5023c4d56c8b11e9c75f9f8bd69894452
achow101 merged this on Feb 6, 2024
achow101 closed this on Feb 6, 2024
furszy deleted the branch on Feb 6, 2024
bitcoin locked this on Feb 5, 2025