ensure we don't listen when using -tor #2939

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:noUPNPTor changing 1 files +4 −0

Diapolo commented at 11:24 AM on August 25, 2013: none
- this also leads to soft-setting -upnp=0 when using Tor, which fixes #2927

ensure we don't listen when using -tor

- this also leads to soft-setting -upnp=0 when using Tor, which fixes
  #2927

0c3b1b5639

gmaxwell commented at 12:26 PM on August 25, 2013: contributor

No, this isn't what we want. This will break hidden services. See doc/tor.md. Normally you set -proxy= when you want to use the proxy exclusively, and that disables listening by default. #2927 already has listen=0 in any case.
BitcoinPullTester commented at 12:31 PM on August 25, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/0c3b1b56397f8d191ef6df589a38b43e9ab07c5d for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 2:03 PM on August 25, 2013: member

NAK. Just -tor shouldn't disable UPnP; -nolisten and -proxy should, but already do, AFAICS.
Diapolo commented at 6:48 AM on August 26, 2013: none

@gmaxwell Just to get this clear, when I use -tor this is for reaching Tor addresses (hidden services) and this patch would disable listening, if not explicitly enabled and would also lead to disable -upnp and -discover (if not explicitly enabled). How does this break hidden services? @sipa I guess the patch should be changed to do this for -onlynet=Tor then?
gmaxwell commented at 6:51 AM on August 26, 2013: contributor

@Diapolo because you could no longer receive incoming connections from other hidden service peers. If you intended to have no non-tor connectivity at all you should instead be using proxy. Perhaps this could be better documented.

No, this shouldn't disable listening for onlynet=tor either, since that will break hidden service inbound too. It should probably disable UPNP when onlynet=tor, however.
Diapolo commented at 7:25 AM on August 26, 2013: none

@gmaxwell Right, incoming connections would be disabled that way.

When I setup Tor and want bitcoin to only use Tor I do this via -proxy=127.0.0.1:9050 -externalip=XYZ.onion -onlynet="Tor" -bind=127.0.0.1 (perhaps that configuration should be mentioned in tor.md?), which explicitly ENABLES incoming connections.
Diapolo commented at 8:45 AM on August 26, 2013: none

@gmaxwell I'll close this, would be nice if you could comment my above posting.
Diapolo closed this on Aug 26, 2013
Diapolo deleted the branch on Aug 26, 2013
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#2927 UPNP is not disabled when tor-only settings are in effect.