The string s represents the value from -whitelist/-whitebind (e.g. "bloom,forcerelay,noban@1.2.3.4:32") and it is used in NetWhitelistPermissions::TryParse and NetWhitebindPermissions::TryParse. However, a max length of 32 is not enough to cover a lot of cases. Even disconsidering the permissions, 32 would not be enough to cover a lot of addresses. This PR fixes it.
fuzz: increase length of string used for `NetWhitelist{bind}Permissions::TryParse` #29413
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2024-02-fuzz-net-permissions changing 1 files +1 −1-
brunoerg commented at 6:55 PM on February 8, 2024: contributor
-
fuzz: increase length of string used for `NetWhitelist{bind}Permissions::TryParse` 864e2e9097
-
DrahtBot commented at 6:55 PM on February 8, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko, vasild, epiccurious If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Feb 8, 2024
-
epiccurious commented at 3:33 AM on February 9, 2024: contributor
If a length of 32 is insufficient, why did you choose 1000 vs 100 or 10,000?
-
maflcko commented at 8:20 AM on February 9, 2024: member
lgtm ACK 864e2e9097de8f1fda63137f803687dd5cc96c03
-
brunoerg commented at 12:03 PM on February 9, 2024: contributor
If a length of 32 is insufficient, why did you choose 1000 vs 100 or 10,000?
Because 1000 is a good value considering current possible combinations of permissions and addresses. 100 is not enough and bigger values like 10,000 might be a waste since these flags are set by users and can't be explored by third parties.
- vasild approved
-
vasild commented at 12:47 PM on February 9, 2024: contributor
ACK 864e2e9097de8f1fda63137f803687dd5cc96c03
- epiccurious approved
-
epiccurious commented at 2:26 PM on February 9, 2024: contributor
utACK 864e2e9097de8f1fda63137f803687dd5cc96c03.
-
maflcko commented at 2:31 PM on February 13, 2024: member
rfm?
- fanquake merged this on Feb 13, 2024
- fanquake closed this on Feb 13, 2024
- PastaPastaPasta referenced this in commit e3eca1dbf9 on Oct 24, 2024
- PastaPastaPasta referenced this in commit 9963e6bc28 on Oct 24, 2024
- PastaPastaPasta referenced this in commit aaccc9ea51 on Oct 24, 2024
- bitcoin locked this on Feb 12, 2025
