test: Fix intermittent issue in interface_rest.py #29467

1. 
   maflcko commented at 6:40 PM on February 22, 2024: member

   Fixes:

    test  2024-02-22T16:15:37.465000Z TestFramework (ERROR): Assertion failed 
     Traceback (most recent call last):
     File "/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main
      self.run_test()
     File "/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/interface_rest.py", line 340, in run_test
      assert_equal(json_obj, mempool_info)
     File "/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 57, in assert_equal
      raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
    AssertionError: not({'loaded': True, 'size': 3, 'bytes': 312, 'usage': 3600, 'total_fee': Decimal('0.00093600'), 'maxmempool': 300000000, 'mempoolminfee': Decimal('0.00001000'), 'minrelaytxfee': Decimal('0.00001000'), 'incrementalrelayfee': Decimal('0.00001000'), 'unbroadcastcount': 1, 'fullrbf': False} == {'loaded': True, 'size': 3, 'bytes': 312, 'usage': 3600, 'total_fee': Decimal('0.00093600'), 'maxmempool': 300000000, 'mempoolminfee': Decimal('0.00001000'), 'minrelaytxfee': Decimal('0.00001000'), 'incrementalrelayfee': Decimal('0.00001000'), 'unbroadcastcount': 0, 'fullrbf': False})
   

   https://cirrus-ci.com/task/4852944378527744?logs=ci#L4436

2. test: Fix intermittent issue in interface_rest.py faeed91c0b
3. 
   DrahtBot commented at 6:40 PM on February 22, 2024: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	mzumsande, m3dwards

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Feb 22, 2024
5. 
   mzumsande commented at 8:36 PM on February 22, 2024: contributor

   ACK faeed91c0be6e5dda4790522d0dc999afd869d11

   The problem seems to be that the existing sync_all waits until the mempool sizes are identical, but the call to RemoveUnbroadcastTx() is executed right after sending the tx in ProcessGetData(), so nothing waits for that. An alternative fix might be to switch the order in ProcessGetData() (call RemoveUnbroadcastTx() right before MakeAndPushMessage() instead of right after).

6. maflcko added this to the milestone 27.0 on Feb 23, 2024
7. 
   m3dwards commented at 12:16 PM on February 26, 2024: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/29467/commits/faeed91c0be6e5dda4790522d0dc999afd869d11

   Tested on ARM Mac.

   I personally haven't seen that flake yet but @mzumsande's explanation for why it can happen makes sense to me and this seems like a pragmatic solution to the test failing.

8. fanquake merged this on Feb 26, 2024
9. fanquake closed this on Feb 26, 2024

   ---

10. maflcko deleted the branch on Feb 26, 2024
11. bitcoin locked this on Feb 25, 2025

Milestone
27.0