RPC: add getrawchangeaddress, for raw transaction change destinations #2948

pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:changeaddr changing 3 files +25 −0
  1. jgarzik commented at 6:27 PM on August 28, 2013: contributor

    Lacking access to change addresses was a bit of a hole in the raw transaction functionality, I've found.

    It was named "getraw..." to emphasize this is not for normal use.

    The current definition of a change address, AFAICS: in the wallet, but not address book.

  2. RPC: add getrawchangeaddress, for raw transaction change destinations e5e9904c1c
  3. gmaxwell commented at 4:09 PM on August 30, 2013: contributor

    I wonder if createrawtransaction shouldn't support something like {"1aaaa":1.0,"change":1.0} and {"1Aaaa":1.0,"fee":1.0} the latter failing if the inputs are not known to it.

  4. BitcoinPullTester commented at 4:09 PM on September 1, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e5e9904c1c87fcdddf01e563ffe28cc56aea4f29 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  5. sipa commented at 6:50 PM on September 1, 2013: member

    @gmaxwell I'd like to see such "magic" targets (fee, change) as well. I suppose the logic would be: if change is specified, it's replaced by a random change address pulled (and marked) in your wallet. If fee is present, it must be the exact different between inputs and outputs.

  6. jgarzik commented at 7:24 PM on September 1, 2013: contributor

    @sipa +1

  7. gavinandresen commented at 10:12 PM on September 2, 2013: contributor

    Another @sipa +1

    This pull: looks good to me, ACK.

  8. gmaxwell commented at 3:28 AM on September 3, 2013: contributor

    ACK.

  9. gmaxwell referenced this in commit dd30937ce3 on Sep 3, 2013
  10. gmaxwell merged this on Sep 3, 2013
  11. gmaxwell closed this on Sep 3, 2013

  12. jgarzik deleted the branch on Aug 24, 2014
  13. Bushstar referenced this in commit 66b336c937 on Apr 8, 2020
  14. Bushstar referenced this in commit 46c4f58441 on Apr 8, 2020
  15. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 00:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me