test: Remove Windows-specific code from system_tests/run_command #29489

1. 
   hebasto commented at 4:01 pm on February 27, 2024: member

   The removed code has been dead since #28967.

   Required as a precondition for replacing Boost.Process with cpp-subprocess to make diff for this code meaningful and reviewable.

   The plan is to reintroduce Windows-specific code in this test simultaneously with enabling Windows support in cpp-subprocess.

2. test: Remove Windows-specific code from `system_tests/run_command`

   This code has been dead since https://github.com/bitcoin/bitcoin/pull/28967.
   
   Required as a precondition for replacing Boost.Process with
   cpp-subprocess to make diff for this code meaningful and reviewable.
   
   The plan is to reintroduce Windows-specific code in this test
   simultaneously with enabling Windows support in cpp-subprocess.

   51bc1c7126
3. 
   DrahtBot commented at 4:01 pm on February 27, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	Sjors, theStack

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28286 (test: Minor fix in test - locale in terminal by crywolf)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Tests on Feb 27, 2024
5. 
   hebasto commented at 4:02 pm on February 27, 2024: member

   cc @fanquake @theStack @Sjors
6. 
   Sjors commented at 4:12 pm on February 27, 2024: member

   utACK 51bc1c7126d6e130bc40c529fb71ae6486da0492
7. theStack approved
8. 
   theStack commented at 2:26 pm on February 28, 2024: contributor

   Code-review ACK 51bc1c7126d6e130bc40c529fb71ae6486da0492
9. 
   hebasto commented at 2:29 pm on February 28, 2024: member

   @maflcko Mind having a look into this PR?
10. 
    maflcko commented at 2:42 pm on February 28, 2024: member

    lgtm
11. 
    fanquake commented at 10:26 pm on February 28, 2024: member

    Also slightly simplifies #27897, which was deleting some of this code.
12. fanquake merged this on Feb 28, 2024
13. fanquake closed this on Feb 28, 2024

    ---

14. hebasto deleted the branch on Feb 29, 2024
15. bitcoin locked this on Feb 28, 2025

Contributors
hebasto DrahtBot Sjors theStack maflcko fanquake

Labels
Tests