build, msvc: Do not compile redundant sources #29533

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240301-qt-test changing 1 files +1 −7
  1. hebasto commented at 11:15 pm on March 1, 2024: member

    The test\util\setup_common.cpp and wallet\test\util.cpp sources are already compiled and included in the libtest_util library, which is linked to the test_bitcoin-qt.exe binary. This PR follows the same logic as Makefile.qttest.include.

    Useful for comparing project files across the master branch and the developing cmake-staging branch.

  2. build, msvc: Do not compile redundant sources
    The `test\util\setup_common.cpp` and `wallet\test\util.cpp` sources are
    already compiled and included in the `libtest_util` library, which is
    linked to the `test_bitcoin-qt.exe` binary. This change follows the same
    logic as `Makefile.qttest.include`.
    6962c66b4a
  3. hebasto added the label Windows on Mar 1, 2024
  4. hebasto added the label Build system on Mar 1, 2024
  5. hebasto added the label Tests on Mar 1, 2024
  6. DrahtBot commented at 11:15 pm on March 1, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK sipsorcery

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  7. hebasto commented at 11:30 pm on March 1, 2024: member
    Friendly ping @sipsorcery :)
  8. sipsorcery commented at 10:18 pm on March 2, 2024: member
    utACK 6962c66b4a9657fd2a6fcca8e9a31beb90d13924.
  9. fanquake merged this on Mar 4, 2024
  10. fanquake closed this on Mar 4, 2024

  11. hebasto deleted the branch on Mar 4, 2024
  12. bitcoin deleted a comment on Mar 4, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-06-29 07:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me