ci: Fix functional tests step for pull requests in Windows GHA job #29535

1. 
   hebasto commented at 0:45 am on March 2, 2024: member

   This functionality has been broken since the Windows runner image version 20240128.1.0.

   Fixes #29534.

2. 
   DrahtBot commented at 0:45 am on March 2, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake, m3dwards

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on Mar 2, 2024
4. hebasto force-pushed on Mar 2, 2024
5. hebasto force-pushed on Mar 2, 2024
6. ci: Fix functional tests step for pull requests in Windows GHA job

   This functionality has been broken since the Windows runner image
   version `20240128.1.0`.

   57e6e2279e
7. hebasto force-pushed on Mar 2, 2024
8. hebasto marked this as ready for review on Mar 2, 2024
9. hebasto added this to the milestone 27.0 on Mar 3, 2024
10. 
    hebasto commented at 2:05 pm on March 4, 2024: member

    cc @maflcko
11. 
    fanquake commented at 5:03 pm on March 5, 2024: member

    I can ACK 57e6e2279ee5562fe31eb418d9bcd8b80634ec8b this only based on the fact that in this PR, the native Windows functional tests run: https://github.com/bitcoin/bitcoin/actions/runs/8119259315/job/22194887783#step:27:72, and that the native Windows functional tests are not currently running on master: https://github.com/bitcoin/bitcoin/actions/runs/8131828989/job/22239779585#step:27:63.

    However it’s not at all clear from the PR description or linked issue what broke, why it did, is this an intermittent thing, is there an upstream issue etc

    Feels like these images should be pinned if they are going to randomly break, and then our tests will silently stop running?

12. 
    hebasto commented at 5:12 pm on March 5, 2024: member

    I doubt whether image version pinning is available.

    Regarding the root of the issue, I suspect a PowerShell version update. However, I cannot confirm it at this moment.

    – Hennadii Stepanov

    On Tue, 5 Mar 2024 at 17:03, fanquake @.***> wrote:

    I can ACK 57e6e22 https://github.com/bitcoin/bitcoin/commit/57e6e2279ee5562fe31eb418d9bcd8b80634ec8b this only based on the fact that in this PR, the native Windows functional tests run: https://github.com/bitcoin/bitcoin/actions/runs/8119259315/job/22194887783#step:27:72, and that the native Windows functional tests are not currently running on master: https://github.com/bitcoin/bitcoin/actions/runs/8131828989/job/22239779585#step:27:63 .

    However it’s not at all clear from the PR description or linked issue what broke, why it did, is this an intermittent thing, is there an upstream issue etc

    Feels like these images should be pinned if they are going to randomly break, and then our tests will silently stop running?

    — Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/29535#issuecomment-1979236029, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3PXPQMMFYFNOESMDHC5XLYWX3HZAVCNFSM6AAAAABECUBYRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZZGIZTMMBSHE . You are receiving this because you authored the thread.Message ID: @.***>

13. 
    m3dwards commented at 5:13 pm on March 5, 2024: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/29535/commits/57e6e2279ee5562fe31eb418d9bcd8b80634ec8b as a way to get the tests running again quickly.

    As a follow up I think that it would be good to know it doesn’t work on powershell and also why the test runner complaining that ’’ isn’t a valid test isn’t a failure.

14. 
    fanquake commented at 5:16 pm on March 5, 2024: member

    Looks like we could/should also change the test_runner exit condition for the no valid scripts case, from 0 to 1, so that it is an error. @m3dwards you might want to follow up with that?
15. fanquake merged this on Mar 5, 2024
16. fanquake closed this on Mar 5, 2024

    ---

17. fanquake referenced this in commit 59567d7b9a on Mar 7, 2024
18. hebasto deleted the branch on Mar 7, 2024
19. PastaPastaPasta referenced this in commit d2c0d4b2ca on Oct 24, 2024
20. PastaPastaPasta referenced this in commit 3e33fc7bbe on Oct 24, 2024
21. PastaPastaPasta referenced this in commit 4dce690a5e on Oct 24, 2024
22. bitcoin locked this on Mar 7, 2025

Contributors
hebasto DrahtBot fanquake m3dwards

Labels
Tests

Milestone
27.0