Changed "Addresses" tab to "Address book" in GUI #2956

Title says it all -- this is because of a confusion in #bitcoin-dev by a user who didn't realize at first that these addresses weren't his.

I dont like this, as I remember we had such a discussion some months ago an decided to leave it as is. If we change things everytime a user complains, we should immediately restart to work on the progressbar :-D.

I saw a really interesting multi-step failure from an experienced Bitcoin user:

They imported a private key from some third party (I didn't ask I assume it was a contest or something).

Much later they needed to receive some Bitcoin so they picked an address of their receive page.

Sometime after that they noticed a transaction they didn't make taking some of their bitcoin.

They eventually figured out that they'd picked that imported key and send coin there and someone else eventually noticed and spent it.

Discussion about this ("Why would someone pull an address from the list??") resulted in me discovering that we were prompting for a password on new addresses (now fixed).

But just another point to confirm my agreement with @wumpus that we should probably bury the lists as historical data, and have a receive page like Armory's.

@laanwj Can you also make a small comment here?

WTF, I thought I already replied here.

NACK. This was rejected before, mainly because Address Book is too long in some languages.

I agree with @gmaxwell though. We need to get rid of receiving and sending addresses and bury them as historical data. The current process encourages address reuse. See #2383.

Is there something else that we could change it to that wouldn't be too long? I agree that it should be (re)moved, but having it just say "Addresses" seems like a bad thing -- IMO it needs to be made clearer that these addresses are addresses that you've saved for sending.

On Saturday, August 31, 2013, Wladimir J. van der Laan wrote:

WTF, I thought I already replied here.

NACK. This was rejected before, mainly because Address Book is too long in some languages.

I agree with @gmaxwell https://github.com/gmaxwell though. We need to get rid of receiving and sending addresses and bury them as historical data. The current process encourages address reuse. See #2383https://github.com/bitcoin/bitcoin/issues/2383.

— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/2956#issuecomment-23607250 .

Sure if you can think of something better to change it to, be my guest.

Tho I'd prefer to not change the string before they get removed anyway, as this will only get the translators more work.

How about "Other peoples' Bitcoin addresses that you have saved in order to send Bitcoins to, even though you shouldn't save and reuse these addresses"? ;-)

Seriously though, I'll think about it and if I think of something I'll come back.