Fixes #29584
On default legacy wallets, the backup filename starts with an “-” due to the wallet name being empty. This is inconvenient for systems who treat what follows the initial “-” character as flags.
Note: As the user can freely set the wallet name to anything, we could also guard the backup filename against other inconvenient characters in the future (we need to be careful here, because the wallet name could also be a path).
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | brunoerg, vasild, achow101 |
| Stale ACK | laanwj, BrandonOdiwuor, murchandamus |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Thank you !
Code review ACK 21ef8221eb473543e61f64953dacb488cdc556d8
528@@ -529,11 +529,20 @@ def test_default_wallet(self):
529 self.log.info("Test migration of the wallet named as the empty string")
530 wallet = self.create_legacy_wallet("")
531
532- self.migrate_wallet(wallet)
533+ # Move time to have a unique name
534+ curr_time = int(time.time()) + 100
535+ wallet.setmocktime(curr_time)
536+
537+ res = self.migrate_wallet(wallet)
why do you add 100 instead of just using the current time?
Just because I coded it while we were on the weekly meeting.. and took time.time() as the node’s mocked time. Fixed. Thanks.
On default legacy wallets, the backup filename starts with an "-" due
to the wallet name being empty. This is inconvenient for systems who
treat what follows the initial "-" character as flags.
