refactor: Reserve memory for ToLower/ToUpper conversions #29606

pull paplorinc wants to merge 1 commits into bitcoin:master from paplorinc:paplorinc/reserve-case-conversion changing 1 files +2 −0
  1. paplorinc commented at 10:07 pm on March 8, 2024: contributor
    Similarly to #29458, we’re preallocating the result string based on the input string’s length. The methods were already covered by tests.
  2. Reserve memory for ToLower/ToUpper conversions 6f2f4a4d09
  3. DrahtBot commented at 10:07 pm on March 8, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK tdb3, Empact, maflcko, stickies-v, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Refactoring on Mar 8, 2024
  5. tdb3 commented at 0:44 am on March 9, 2024: contributor
    ACK for 6f2f4a4d096a3b261258c8cdd96cca532988d1d3 Cloned, built, ran all unit and functional tests (all passed).
  6. jess2505 approved
  7. Empact approved
  8. Empact approved
  9. maflcko commented at 9:55 am on March 11, 2024: member
    lgtm ACK 6f2f4a4d096a3b261258c8cdd96cca532988d1d3
  10. stickies-v approved
  11. stickies-v commented at 5:12 pm on March 12, 2024: contributor
    ACK 6f2f4a4d096a3b261258c8cdd96cca532988d1d3
  12. achow101 commented at 11:29 am on March 13, 2024: member
    ACK 6f2f4a4d096a3b261258c8cdd96cca532988d1d3
  13. achow101 merged this on Mar 13, 2024
  14. achow101 closed this on Mar 13, 2024

  15. luke-jr referenced this in commit 2435c39a6c on Mar 14, 2024
  16. paplorinc deleted the branch on May 11, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-28 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me