Reviewing #29585, I noticed that bitcoin-qt adds an extra newline for -help and -version beyond the other binaries'.
Bugfix: GUI: Help messages already have a trailing newline, so don't add an extra one #29658
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:fix_qt_help_on_console_x_newline changing 1 files +1 −1-
luke-jr commented at 12:40 AM on March 15, 2024: member
-
Bugfix: GUI: Help messages already have a trailing newline, so don't add an extra one d1ed09a764
-
DrahtBot commented at 12:40 AM on March 15, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- fanquake requested review from hebasto on Mar 19, 2024
- hernanmarino approved
-
pablomartin4btc commented at 2:30 PM on April 15, 2024: member
I think this should be moved to the QT gui repo.
- hebasto approved
-
hebasto commented at 1:17 PM on May 12, 2024: member
ACK d1ed09a7643b567e021b2ecb756bc925c48fc708, tested on Ubuntu 24.04.
This change indeed aligns the behavior of
bitcoin-qtwith that ofbitcoindand other Bitcoin Core binaries. - hebasto merged this on May 12, 2024
- hebasto closed this on May 12, 2024
- PastaPastaPasta referenced this in commit 9c85378443 on Oct 25, 2024
- PastaPastaPasta referenced this in commit 700b8c5ac5 on Oct 26, 2024
- PastaPastaPasta referenced this in commit f211bb9289 on Oct 27, 2024
- bitcoin locked this on May 14, 2025
