Don't warn about forks while fIsInitialDownload #2968

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:master changing 1 files +5 −0

TheBlueMatt commented at 2:10 AM on September 4, 2013: member

This is a cheap hack to address the warnings people get during initial download, feel free to discard in favor of something more reasonable.
BitcoinPullTester commented at 2:19 AM on September 4, 2013: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/c35d9c0952c41af08c48aab907d3aae1a2d8ee10 for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in contrib/test-scripts)
2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Don't warn about forks while fIsInitialDownload 55ed3f1475
BitcoinPullTester commented at 2:59 AM on September 4, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/55ed3f14751206fc87f0cbf8cb4e223efacef338 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 9:24 AM on September 4, 2013: none

Seems reasonable...
laanwj commented at 12:05 PM on September 5, 2013: member

This will hide the warning, but is that the entire problem? will the block chain download continue?
TheBlueMatt commented at 2:00 PM on September 5, 2013: member

The warning doesn't effect the download at all, and is generated sometimes when a "fork" is detected because we get blocks while we were in initial download.
laanwj commented at 2:33 PM on September 5, 2013: member

ACK in that case
wtogami commented at 12:34 AM on September 8, 2013: contributor

ACK
gavinandresen referenced this in commit 4c723841e2 on Sep 9, 2013
gavinandresen merged this on Sep 9, 2013
gavinandresen closed this on Sep 9, 2013
Bushstar referenced this in commit 56d1d13c43 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors