lint: scripted-diff verification also requires GNU grep #29689

1. 
   Sjors commented at 12:15 pm on March 21, 2024: member

   I noticed while trying to verify all historical scripted-diff: commits on macOS that some scripts require GNU sed.

   For example 0d6d2b650d1017691f48c9109a6cd020ab46aa73 uses git grep --perl-regexp.

2. lint: scripted-diff verification also requires GNU grep 3bf4f8db66
3. 
   DrahtBot commented at 12:15 pm on March 21, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hernanmarino, alfonsoromanz, maflcko, kristapsk, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Mar 21, 2024
5. 
   Sjors commented at 3:46 pm on March 21, 2024: member

   Looks like CI is / was doing this too: https://github.com/bitcoin/bitcoin/commit/cd82f75a431967030d25bcfe7c4aaefe5b345a99
6. 
   hernanmarino commented at 8:09 pm on April 9, 2024: contributor

   cr ACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
7. alfonsoromanz approved
8. 
   alfonsoromanz commented at 10:45 pm on April 24, 2024: none

   Tested ACK 3bf4f8db669e1e274ce2633cf84add2938b9914b

   I was using incompatible versions for both sed and grep, so I was able to verify both error messages. After installing the GNU versions I don’t get any of the error messages.

9. 
   maflcko commented at 5:28 am on April 25, 2024: member

   utACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
10. kristapsk approved
11. 
    kristapsk commented at 8:51 am on April 25, 2024: contributor

    cr utACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
12. 
    achow101 commented at 4:34 pm on April 25, 2024: member

    ACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
13. achow101 merged this on Apr 25, 2024
14. achow101 closed this on Apr 25, 2024

    ---

15. Sjors deleted the branch on Apr 26, 2024

Contributors
Sjors DrahtBot hernanmarino alfonsoromanz maflcko kristapsk achow101

Labels
Tests