I noticed while trying to verify all historical scripted-diff: commits on macOS that some scripts require GNU sed.
For example 0d6d2b650d1017691f48c9109a6cd020ab46aa73 uses git grep --perl-regexp.
lint: scripted-diff verification also requires GNU grep #29689
pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2024/03/tu-quoque-grep changing 1 files +5 −0-
Sjors commented at 12:15 PM on March 21, 2024: member
-
lint: scripted-diff verification also requires GNU grep 3bf4f8db66
-
DrahtBot commented at 12:15 PM on March 21, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hernanmarino, alfonsoromanz, maflcko, kristapsk, achow101 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Mar 21, 2024
-
Sjors commented at 3:46 PM on March 21, 2024: member
Looks like CI is / was doing this too: https://github.com/bitcoin/bitcoin/commit/cd82f75a431967030d25bcfe7c4aaefe5b345a99
-
hernanmarino commented at 8:09 PM on April 9, 2024: contributor
cr ACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
- alfonsoromanz approved
-
alfonsoromanz commented at 10:45 PM on April 24, 2024: contributor
Tested ACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
I was using incompatible versions for both sed and grep, so I was able to verify both error messages. After installing the GNU versions I don't get any of the error messages.
-
maflcko commented at 5:28 AM on April 25, 2024: member
utACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
- kristapsk approved
-
kristapsk commented at 8:51 AM on April 25, 2024: contributor
cr utACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
-
achow101 commented at 4:34 PM on April 25, 2024: member
ACK 3bf4f8db669e1e274ce2633cf84add2938b9914b
- achow101 merged this on Apr 25, 2024
- achow101 closed this on Apr 25, 2024
- Sjors deleted the branch on Apr 26, 2024
- PastaPastaPasta referenced this in commit e4fdd5e9a7 on Oct 25, 2024
- PastaPastaPasta referenced this in commit a7daee71da on Oct 26, 2024
- PastaPastaPasta referenced this in commit f211bb9289 on Oct 27, 2024
- bitcoin locked this on Apr 26, 2025
