bench: Adds a benchmark for CheckInputScripts #29745

1. 
   kevkevinpal commented at 11:43 pm on March 26, 2024: contributor

   Creates new benchmark for CheckInputScripts

   Motivated by this comment #17175 (comment)

   I haven’t really done benchmarking a ton before so any comments would be useful

   What the benchmark looks like when I run ./src/bench/bench_bitcoin

   0|           ns/script |            script/s |    err% |     total | benchmark
   1|--------------------:|--------------------:|--------:|----------:|:----------
   2|            6,946.20 |          143,963.61 |    5.2% |      0.01 | :wavy_dash: `BenchCheckInputScripts` (Unstable with ~148.0 iters. Increase `minEpochIterations` to e.g. 1480)
   

2. 
   DrahtBot commented at 11:43 pm on March 26, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30141 (kernel: De-globalize validation caches by TheCharlatan)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Tests on Mar 26, 2024
4. kevkevinpal force-pushed on Mar 26, 2024
5. DrahtBot added the label CI failed on Mar 26, 2024
6. 
   DrahtBot commented at 11:55 pm on March 26, 2024: contributor

   🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.

   Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   Leave a comment here, if you need help tracking down a confusing failure.

   Debug: https://github.com/bitcoin/bitcoin/runs/23129699098

7. bench: Adds a benchmark for CheckInputScripts 22d87594e6
8. kevkevinpal force-pushed on Mar 27, 2024
9. 
   kevkevinpal commented at 1:33 am on March 27, 2024: contributor

   looks like the checks are failing because it requires cs_main mutex so I’ll see what I can do about that
10. kevkevinpal marked this as a draft on Mar 27, 2024
11. in src/Makefile.bench.include:15 in 22d87594e6

    11@@ -12,6 +12,7 @@ GENERATED_BENCH_FILES = $(RAW_BENCH_FILES:.raw=.raw.h)
    12 
    13 bench_bench_bitcoin_SOURCES = \
    14   $(RAW_BENCH_FILES) \
    15+  bench/check_input_scrips.cpp \
    

    ---

    ---

    

    l0rinc commented at 6:21 pm on March 27, 2024:

    the rest of the benchmarks are in alphabetical order
12. in src/validation.cpp:136 in 22d87594e6

    132@@ -133,12 +133,6 @@ const CBlockIndex* Chainstate::FindForkInGlobalIndex(const CBlockLocator& locato
    133     return m_chain.Genesis();
    134 }
    135 
    136-bool CheckInputScripts(const CTransaction& tx, TxValidationState& state,
    

    ---

    ---

    

    l0rinc commented at 6:23 pm on March 27, 2024:

    please separate production changes from benchmark changes into commits with focused explanations
13. 
    DrahtBot commented at 5:24 pm on June 18, 2024: contributor

    Are you still working on this?
14. DrahtBot added the label Needs rebase on Jul 8, 2024
15. 
    DrahtBot commented at 5:00 pm on July 8, 2024: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

16. 
    DrahtBot commented at 1:37 am on October 5, 2024: contributor

    ⌛ There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
17. maflcko closed this on Oct 9, 2024

    ---

18. 
    maflcko commented at 4:21 pm on October 9, 2024: member

    Closing for now due to inactivity since the day it was opened. Leave a comment below if you want this re-opened, or open a new pull.
19. 
    kevkevinpal commented at 4:37 pm on October 9, 2024: contributor

    Closing for now due to inactivity since the day it was opened. Leave a comment below if you want this re-opened, or open a new pull.

    ya sorry about that I can leave it up for grabs if anyone else wants to look at it otherwise I can reopen when I have a more finalized PR open, again sorry for leaving it open but inactive

Contributors
kevkevinpal DrahtBot l0rinc maflcko

Labels
Tests Needs rebase CI failed