depends: fix mingw-w64 Qt DEBUG=1 build

fanquake commented at 10:57 am on March 27, 2024: member

The issue is that compilation is done with x86_64-w64-mingw32-g++-posix, but then linking is done with x86_64-w64-mingw32-g++.

I’m guessing this has been broken since #24131 (01d1845a80ae48d741deea695ddce95d940ab0d8), but have not checked.

Fixes #29734. Unblocks #29527 (DEBUG=1 builds can be tested).

The issue is that compilation is done with `x86_64-w64-mingw32-g++-posix`,
but then linking is done with `x86_64-w64-mingw32-g++`.

I'm guessing this has been broken since #24131
(01d1845a80ae48d741deea695ddce95d940ab0d8), but have not checked.

Fixes #29734.
Unblocks #29527 (now DEBUG=1 builds can be tested).

b7e7e727ab

DrahtBot commented at 10:57 am on March 27, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Build system on Mar 27, 2024

fanquake commented at 1:44 pm on March 27, 2024: member

Guix Build (aarch64):

 0979178d40158693d10fef1897f3dfd1f0fbfd008a92b1fd27713cb66e5b8b8fa  guix-build-b7e7e727abd8/output/aarch64-linux-gnu/SHA256SUMS.part
 136bf67bc413ede45788a1f1cb31c83839d0f59c49e8bbf52e811854a54fe936c  guix-build-b7e7e727abd8/output/aarch64-linux-gnu/bitcoin-b7e7e727abd8-aarch64-linux-gnu-debug.tar.gz
 28a5331e33ab1a23eb037841127905cbc2346ca5b84b6d1dbc6cd0a2682a4b0a5  guix-build-b7e7e727abd8/output/aarch64-linux-gnu/bitcoin-b7e7e727abd8-aarch64-linux-gnu.tar.gz
 312d03eb52ef823231b2afc4632a70139ff3e7195966c76090f5da640c90f0695  guix-build-b7e7e727abd8/output/arm-linux-gnueabihf/SHA256SUMS.part
 488ba75a674bb8ec537dfefdeac43785be0621ed4241be8cb858514498d98b1ef  guix-build-b7e7e727abd8/output/arm-linux-gnueabihf/bitcoin-b7e7e727abd8-arm-linux-gnueabihf-debug.tar.gz
 5356f9fb063360a49b263f326f1eabec36182c32a835019fb74aa7e2dc82c746e  guix-build-b7e7e727abd8/output/arm-linux-gnueabihf/bitcoin-b7e7e727abd8-arm-linux-gnueabihf.tar.gz
 6b7729d054d11f9d6a8e41cf511e3f0828cb5026878bce46951435cb56bdc1f4b  guix-build-b7e7e727abd8/output/arm64-apple-darwin/SHA256SUMS.part
 70a69c56d7d6caf6dd9018be08f18cca7ee3007d2a10f31fa4cb25698a5b0ff7a  guix-build-b7e7e727abd8/output/arm64-apple-darwin/bitcoin-b7e7e727abd8-arm64-apple-darwin-unsigned.tar.gz
 89ff5fb61733fa9c835118b40eb2afdf0d3c383765d03bb8d7ab62d3f527fdc5e  guix-build-b7e7e727abd8/output/arm64-apple-darwin/bitcoin-b7e7e727abd8-arm64-apple-darwin-unsigned.zip
 9dccd31f8e0be03848ae6d122536939821d1f37fe35a737651cf3a47dccd11eb3  guix-build-b7e7e727abd8/output/arm64-apple-darwin/bitcoin-b7e7e727abd8-arm64-apple-darwin.tar.gz
104c8169021c505f45d144cffe4a5db307e23a21c6e9dc7ad80a6fc396ada8fcca  guix-build-b7e7e727abd8/output/dist-archive/bitcoin-b7e7e727abd8.tar.gz
113c315c7872a4b818474525775f8b0ffadbe1ff61e84b274cd579593161665fd9  guix-build-b7e7e727abd8/output/powerpc64-linux-gnu/SHA256SUMS.part
12f512dcf753b266530455fe2618be5f8717d9175a24c3b0c59b02b620f3bf2930  guix-build-b7e7e727abd8/output/powerpc64-linux-gnu/bitcoin-b7e7e727abd8-powerpc64-linux-gnu-debug.tar.gz
130274dd47a0a9ccb56253af179a7c9b9a56dad6a563ccf47921389f1ea492613b  guix-build-b7e7e727abd8/output/powerpc64-linux-gnu/bitcoin-b7e7e727abd8-powerpc64-linux-gnu.tar.gz
144d63408693a66ff21710e4eb2f669ec91e310260c64f5826d59721c93e781d15  guix-build-b7e7e727abd8/output/riscv64-linux-gnu/SHA256SUMS.part
155e2838f9819edf3fca5364e807f9453e441ed214b3ead54f3f46f584b71ec4e5  guix-build-b7e7e727abd8/output/riscv64-linux-gnu/bitcoin-b7e7e727abd8-riscv64-linux-gnu-debug.tar.gz
162f24933969e28412493a7ee1cdf381ead4282a5cac8777927216d1b58407e730  guix-build-b7e7e727abd8/output/riscv64-linux-gnu/bitcoin-b7e7e727abd8-riscv64-linux-gnu.tar.gz
17163ee9499534224abe95e92f10c97303035fbf8eb769f25e5bba4b07b2f39923  guix-build-b7e7e727abd8/output/x86_64-apple-darwin/SHA256SUMS.part
188a7e93ee54cb8916d84f577ad3872ae6192a99689ecd7b1cfe5d6fb8092a3363  guix-build-b7e7e727abd8/output/x86_64-apple-darwin/bitcoin-b7e7e727abd8-x86_64-apple-darwin-unsigned.tar.gz
1940e3510fa899127dcb042e67d5d982f19dbd684afdf9169967f544b593189723  guix-build-b7e7e727abd8/output/x86_64-apple-darwin/bitcoin-b7e7e727abd8-x86_64-apple-darwin-unsigned.zip
203bc71d190d783d5f16da7350ed007fbb8a82504715f12ca5fe23f691cf042a9a  guix-build-b7e7e727abd8/output/x86_64-apple-darwin/bitcoin-b7e7e727abd8-x86_64-apple-darwin.tar.gz
21f332354ca500aa3ae7eec0ad2717f8d37815836147aec7a9481e9a6e8b3136b7  guix-build-b7e7e727abd8/output/x86_64-linux-gnu/SHA256SUMS.part
22e8c32366e9e8a91097fbb8ec3dc820f4dcc4cb94ba4321e39ab5803d10019172  guix-build-b7e7e727abd8/output/x86_64-linux-gnu/bitcoin-b7e7e727abd8-x86_64-linux-gnu-debug.tar.gz
23fea1c60824284df3bc55de9649677baef838f780a23b7cb36c811ab5d4608f70  guix-build-b7e7e727abd8/output/x86_64-linux-gnu/bitcoin-b7e7e727abd8-x86_64-linux-gnu.tar.gz
24f6616cad45ea4a0079a9d4a795ae5213841c6278909bdb53e0efeb90da1b0e62  guix-build-b7e7e727abd8/output/x86_64-w64-mingw32/SHA256SUMS.part
252defacfab80d43611f8d044e4dfe6772d88e4ef4ee558d41edbc70e3e61ab4bb  guix-build-b7e7e727abd8/output/x86_64-w64-mingw32/bitcoin-b7e7e727abd8-win64-debug.zip
26af3385820b56abe07734812560fcd238ebd8370f6cb8a15b81ca81b353ce18a3  guix-build-b7e7e727abd8/output/x86_64-w64-mingw32/bitcoin-b7e7e727abd8-win64-setup-unsigned.exe
27eed062fcd8b58e86d855b6898e70ffed84066ac779d530d354698d4f868ab1bf  guix-build-b7e7e727abd8/output/x86_64-w64-mingw32/bitcoin-b7e7e727abd8-win64-unsigned.tar.gz
28944d248217126efbf2e25e3e71f26c46dc64db6852b8b8e2b0bc01c76a650274  guix-build-b7e7e727abd8/output/x86_64-w64-mingw32/bitcoin-b7e7e727abd8-win64.zip

hebasto approved

hebasto commented at 2:05 pm on March 27, 2024: member

ACK b7e7e727abd86104ee58beb648a94e2f453d1f6d, tested on Ubuntu 22.04 with the installed g++-mingw-w64-x86-64 package.

TheCharlatan approved

TheCharlatan commented at 3:51 pm on March 27, 2024: contributor

ACK b7e7e727abd86104ee58beb648a94e2f453d1f6d

Guix builds (x86_64)

 0979178d40158693d10fef1897f3dfd1f0fbfd008a92b1fd27713cb66e5b8b8fa  guix-build-b7e7e727abd8/output/aarch64-linux-gnu/SHA256SUMS.part
 136bf67bc413ede45788a1f1cb31c83839d0f59c49e8bbf52e811854a54fe936c  guix-build-b7e7e727abd8/output/aarch64-linux-gnu/bitcoin-b7e7e727abd8-aarch64-linux-gnu-debug.tar.gz
 28a5331e33ab1a23eb037841127905cbc2346ca5b84b6d1dbc6cd0a2682a4b0a5  guix-build-b7e7e727abd8/output/aarch64-linux-gnu/bitcoin-b7e7e727abd8-aarch64-linux-gnu.tar.gz
 312d03eb52ef823231b2afc4632a70139ff3e7195966c76090f5da640c90f0695  guix-build-b7e7e727abd8/output/arm-linux-gnueabihf/SHA256SUMS.part
 488ba75a674bb8ec537dfefdeac43785be0621ed4241be8cb858514498d98b1ef  guix-build-b7e7e727abd8/output/arm-linux-gnueabihf/bitcoin-b7e7e727abd8-arm-linux-gnueabihf-debug.tar.gz
 5356f9fb063360a49b263f326f1eabec36182c32a835019fb74aa7e2dc82c746e  guix-build-b7e7e727abd8/output/arm-linux-gnueabihf/bitcoin-b7e7e727abd8-arm-linux-gnueabihf.tar.gz
 6b7729d054d11f9d6a8e41cf511e3f0828cb5026878bce46951435cb56bdc1f4b  guix-build-b7e7e727abd8/output/arm64-apple-darwin/SHA256SUMS.part
 70a69c56d7d6caf6dd9018be08f18cca7ee3007d2a10f31fa4cb25698a5b0ff7a  guix-build-b7e7e727abd8/output/arm64-apple-darwin/bitcoin-b7e7e727abd8-arm64-apple-darwin-unsigned.tar.gz
 89ff5fb61733fa9c835118b40eb2afdf0d3c383765d03bb8d7ab62d3f527fdc5e  guix-build-b7e7e727abd8/output/arm64-apple-darwin/bitcoin-b7e7e727abd8-arm64-apple-darwin-unsigned.zip
 9dccd31f8e0be03848ae6d122536939821d1f37fe35a737651cf3a47dccd11eb3  guix-build-b7e7e727abd8/output/arm64-apple-darwin/bitcoin-b7e7e727abd8-arm64-apple-darwin.tar.gz
104c8169021c505f45d144cffe4a5db307e23a21c6e9dc7ad80a6fc396ada8fcca  guix-build-b7e7e727abd8/output/dist-archive/bitcoin-b7e7e727abd8.tar.gz
113c315c7872a4b818474525775f8b0ffadbe1ff61e84b274cd579593161665fd9  guix-build-b7e7e727abd8/output/powerpc64-linux-gnu/SHA256SUMS.part
12f512dcf753b266530455fe2618be5f8717d9175a24c3b0c59b02b620f3bf2930  guix-build-b7e7e727abd8/output/powerpc64-linux-gnu/bitcoin-b7e7e727abd8-powerpc64-linux-gnu-debug.tar.gz
130274dd47a0a9ccb56253af179a7c9b9a56dad6a563ccf47921389f1ea492613b  guix-build-b7e7e727abd8/output/powerpc64-linux-gnu/bitcoin-b7e7e727abd8-powerpc64-linux-gnu.tar.gz
144d63408693a66ff21710e4eb2f669ec91e310260c64f5826d59721c93e781d15  guix-build-b7e7e727abd8/output/riscv64-linux-gnu/SHA256SUMS.part
155e2838f9819edf3fca5364e807f9453e441ed214b3ead54f3f46f584b71ec4e5  guix-build-b7e7e727abd8/output/riscv64-linux-gnu/bitcoin-b7e7e727abd8-riscv64-linux-gnu-debug.tar.gz
162f24933969e28412493a7ee1cdf381ead4282a5cac8777927216d1b58407e730  guix-build-b7e7e727abd8/output/riscv64-linux-gnu/bitcoin-b7e7e727abd8-riscv64-linux-gnu.tar.gz
17163ee9499534224abe95e92f10c97303035fbf8eb769f25e5bba4b07b2f39923  guix-build-b7e7e727abd8/output/x86_64-apple-darwin/SHA256SUMS.part
188a7e93ee54cb8916d84f577ad3872ae6192a99689ecd7b1cfe5d6fb8092a3363  guix-build-b7e7e727abd8/output/x86_64-apple-darwin/bitcoin-b7e7e727abd8-x86_64-apple-darwin-unsigned.tar.gz
1940e3510fa899127dcb042e67d5d982f19dbd684afdf9169967f544b593189723  guix-build-b7e7e727abd8/output/x86_64-apple-darwin/bitcoin-b7e7e727abd8-x86_64-apple-darwin-unsigned.zip
203bc71d190d783d5f16da7350ed007fbb8a82504715f12ca5fe23f691cf042a9a  guix-build-b7e7e727abd8/output/x86_64-apple-darwin/bitcoin-b7e7e727abd8-x86_64-apple-darwin.tar.gz
21f332354ca500aa3ae7eec0ad2717f8d37815836147aec7a9481e9a6e8b3136b7  guix-build-b7e7e727abd8/output/x86_64-linux-gnu/SHA256SUMS.part
22e8c32366e9e8a91097fbb8ec3dc820f4dcc4cb94ba4321e39ab5803d10019172  guix-build-b7e7e727abd8/output/x86_64-linux-gnu/bitcoin-b7e7e727abd8-x86_64-linux-gnu-debug.tar.gz
23fea1c60824284df3bc55de9649677baef838f780a23b7cb36c811ab5d4608f70  guix-build-b7e7e727abd8/output/x86_64-linux-gnu/bitcoin-b7e7e727abd8-x86_64-linux-gnu.tar.gz
24f6616cad45ea4a0079a9d4a795ae5213841c6278909bdb53e0efeb90da1b0e62  guix-build-b7e7e727abd8/output/x86_64-w64-mingw32/SHA256SUMS.part
252defacfab80d43611f8d044e4dfe6772d88e4ef4ee558d41edbc70e3e61ab4bb  guix-build-b7e7e727abd8/output/x86_64-w64-mingw32/bitcoin-b7e7e727abd8-win64-debug.zip
26af3385820b56abe07734812560fcd238ebd8370f6cb8a15b81ca81b353ce18a3  guix-build-b7e7e727abd8/output/x86_64-w64-mingw32/bitcoin-b7e7e727abd8-win64-setup-unsigned.exe
27eed062fcd8b58e86d855b6898e70ffed84066ac779d530d354698d4f868ab1bf  guix-build-b7e7e727abd8/output/x86_64-w64-mingw32/bitcoin-b7e7e727abd8-win64-unsigned.tar.gz
28944d248217126efbf2e25e3e71f26c46dc64db6852b8b8e2b0bc01c76a650274  guix-build-b7e7e727abd8/output/x86_64-w64-mingw32/bitcoin-b7e7e727abd8-win64.zip

fanquake merged this on Mar 27, 2024

fanquake closed this on Mar 27, 2024

fanquake deleted the branch on Mar 27, 2024

fanquake referenced this in commit a6862c50c5 on Apr 16, 2024

fanquake commented at 7:59 am on April 17, 2024: member

Backported to 27.x in #29888.

luke-jr referenced this in commit f20a87a89a on Apr 24, 2024

fanquake referenced this in commit c7885ecd77 on May 13, 2024

glozow referenced this in commit 72f843c05c on May 13, 2024

glozow commented at 9:42 am on May 14, 2024: member

backported to 26.x in #29899

depends: fix mingw-w64 Qt DEBUG=1 build #29747

Code Coverage

Reviews