doc: Suggest installing dev packages for debian/ubuntu qt5 build #29764

1. 
   laanwj commented at 8:34 am on March 29, 2024: member

   Pretty much all library packages were renamed in the 64-bit time_t migration to add t64 (even on 64-bit platforms).

   Instead of complicating the doc with conditional package names, suggest installing the -dev packages which still have the same name, and besides that, are the right way to go about it as they contain the “user facing” C++ headers needed to build against Qt5. They pull in the necessary library packages through dependencies.

   For Fedora, devel packages are already suggested.

   This affects Ubuntu 24.04 and Debian Testing.

2. doc: Suggest installing dev packages for debian/ubuntu qt5 build

   Pretty much all library packages were renamed in the 64-bit time_t
   migration to add `t64` (even on 64-bit platforms).
   
   Instead of complicating the doc with conditional package names, suggest
   installing the `-dev` packages which still have the same name, and
   besides that, are the right way to go about it as they contain the
   "user facing" C++ headers needed to build against Qt5.
   
   For Fedora, devel packages are already suggested.
   
   This affects Ubuntu 24.04 and Debian Testing.

   a3c6a13cb2
3. 
   DrahtBot commented at 8:34 am on March 29, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28710 (Remove the legacy wallet and BDB dependency by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Docs on Mar 29, 2024
5. 
   maflcko commented at 9:03 am on March 29, 2024: member

   Nice catch. If you don’t mind, can you please also update the CI environment at the same time? Currently it still passes, because the image is using a cache, and I presume the package rename happened recently. However, this may break at any time.

   For reference, the CI failure is:

    0MAKEJOBS="-j$(nproc)" FILE_ENV="./ci/test/00_setup_env_native_tidy.sh" ./ci/test_run_all.sh
    1
    2...
    3
    4Reading package lists... Done
    5+ retry -- bash -c 'apt-get install --no-install-recommends --no-upgrade -y clang-18 libclang-18-dev llvm-18-dev libomp-18-dev clang-tidy-18 jq bear libevent-dev libboost-dev libminiupnpc-dev libnatpmp-dev libzmq3-dev systemtap-sdt-dev libqt5gui5 libqt5core5a libqt5dbus5 qttools5-dev qttools5-dev-tools libqrencode-dev libsqlite3-dev libdb++-dev build-essential libtool autotools-dev automake pkg-config bsdmainutils curl ca-certificates ccache python3 rsync git procps bison e2fsprogs cmake'
    6Reading package lists... Done
    7Building dependency tree... Done
    8Reading state information... Done
    9Skipping ca-certificates, it is already installed and upgrade is not set.
   10ca-certificates set to manually installed.
   11Skipping python3, it is already installed and upgrade is not set.
   12Skipping rsync, it is already installed and upgrade is not set.
   13Skipping git, it is already installed and upgrade is not set.
   14Skipping procps, it is already installed and upgrade is not set.
   15Skipping e2fsprogs, it is already installed and upgrade is not set.
   16Some packages could not be installed. This may mean that you have
   17requested an impossible situation or if you are using the unstable
   18distribution that some required packages have not yet been created
   19or been moved out of Incoming.
   20The following information may help to resolve the situation:
   21
   22The following packages have unmet dependencies:
   23 libqt5core5t64 : Breaks: libqt5core5a (< 5.15.12+dfsg-3ubuntu6)
   24 libqt5dbus5t64 : Breaks: libqt5dbus5 (< 5.15.12+dfsg-3ubuntu6)
   25 libqt5gui5t64 : Breaks: libqt5gui5 (< 5.15.12+dfsg-3ubuntu6)
   26E: Unable to correct problems, you have held broken packages.
   27Before retry [#1](/bitcoin-bitcoin/1/): sleeping 0.3 seconds
   28
   29...
   

6. maflcko added the label Needs backport (26.x) on Mar 29, 2024
7. maflcko added this to the milestone 27.0 on Mar 29, 2024
8. 
   hebasto commented at 9:26 am on March 29, 2024: member

   Concept ACK.
9. ci: Pull in qtbase5-dev instead of seperate low-level libraries

   Fix CI build for t64 migration.

   6c2990416e
10. hebasto approved
11. 
    hebasto commented at 10:19 am on March 29, 2024: member

    ACK 6c2990416e2dabd845f5ec50ec6ff138136c9b08.
12. 
    maflcko commented at 10:46 am on March 29, 2024: member

    Thanks

    lgtm ACK 6c2990416e2dabd845f5ec50ec6ff138136c9b08

13. fanquake merged this on Apr 1, 2024
14. fanquake closed this on Apr 1, 2024

    ---

15. fanquake referenced this in commit c4da61b323 on Apr 1, 2024
16. fanquake referenced this in commit 753c68dc0f on Apr 1, 2024
17. 
    fanquake commented at 2:06 pm on April 1, 2024: member

    Pulled into 27.x in #29780.
18. jonatack referenced this in commit a3a344808b on Apr 1, 2024
19. 
    jonatack commented at 4:22 pm on April 1, 2024: contributor

    Updated https://jonatack.github.io/articles/how-to-compile-bitcoin-core-and-run-the-tests. Thanks!
20. fanquake referenced this in commit d82283950f on Apr 15, 2024
21. glozow referenced this in commit f901b4353c on May 13, 2024
22. glozow referenced this in commit 109b9d74f5 on May 13, 2024
23. 
    glozow commented at 9:42 am on May 14, 2024: member

    backported to 26.x in #29899
24. glozow removed the label Needs backport (26.x) on May 14, 2024

Contributors
laanwj DrahtBot maflcko hebasto fanquake jonatack glozow

Labels
Docs

Milestone
27.0