ci: Use clang-18 #29765

1. 
   maflcko commented at 2:22 pm on March 29, 2024: member

   Use clang-18, which comes with bugfixes and sanitizer upgrades.
2. ci: Bump clang+llvm in i686_multiprocess task fad23a0646
3. 
   DrahtBot commented at 2:22 pm on March 29, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #29165 (build: Bump clang minimum supported version to 15 by maflcko)
   • #28710 (Remove the legacy wallet and BDB dependency by achow101)
   • #28687 (C++20 std::views::reverse by stickies-v)
   • #25972 (build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot renamed this:
   ci: Use clang-18
   ci: Use clang-18
   on Mar 29, 2024
5. DrahtBot added the label Tests on Mar 29, 2024
6. 
   fanquake commented at 2:24 pm on March 29, 2024: member

   I don’t think Mac cross should change until depends and guix does?
7. 
   maflcko commented at 2:33 pm on March 29, 2024: member

   Oh I forgot that the pre-built binary has the distro assumed:

   https://github.com/bitcoin/bitcoin/blob/4373414d26ffd2cd004a59a095ce30b433059780/depends/packages/native_llvm.mk#L9

   Maybe a comment can be added that the two must match.

8. ci: Use clang-18 in asan/fuzz/tsan task fa75220ac5
9. maflcko force-pushed on Mar 29, 2024
10. 
    fanquake commented at 2:22 pm on April 1, 2024: member

    has the distro assumed: Maybe a comment can be added that the two must match.

    They don’t necessarily have to, i.e, the “Ubuntu” bins will build macOS binaries on Fedora, or Alpine, for example. Or are you only talking about the version?

11. fanquake approved
12. 
    fanquake commented at 2:22 pm on April 1, 2024: member

    ACK fa75220ac5e0ea401a26dd2f16a88627e51c240a
13. fanquake merged this on Apr 1, 2024
14. fanquake closed this on Apr 1, 2024

    ---

15. maflcko deleted the branch on Apr 1, 2024

Contributors
maflcko DrahtBot fanquake

Labels
Tests