test: remove immediate tx relay workaround in wallet_groups.py #29822

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202404-test-remove_immediate_tx_relay_workaround_wallet_groups_py changing 1 files +0 −5

theStack commented at 4:33 PM on April 6, 2024: contributor

Reverts commit ab4efad51b9ba276ffeb6871931e13772493f7cc (PR #26970). This workaround is not needed anymore, as since #27114 the test sets the noban permission for both in- and outbound connections via the noban_tx_relay setting, and we don't have to rely on this topology hack anymore. See commit c985eb854cc86deb747caea5283c17cf51b6a983 (kudos to brunoerg!).

Can be tested by executing $ time ./test/functional/wallet_groups.py both on master and PR and verifying that the execution time is roughly equal.

test: remove immediate tx relay workaround in wallet_groups.py

Reverts commit ab4efad51b9ba276ffeb6871931e13772493f7cc (PR #26970).
This workaround is not needed anymore, as since #27114 the test sets
the noban permission for both in- and outbound connections via the
`noban_tx_relay` setting, and we don't have to rely on these topology
hacks anymore. See commit c985eb854cc86deb747caea5283c17cf51b6a983.

93fae5ae7c

DrahtBot commented at 4:33 PM on April 6, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK brunoerg, maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Apr 6, 2024
brunoerg approved
brunoerg commented at 9:51 PM on April 6, 2024: contributor

utACK 93fae5ae7c31fa1b1095770f00adeac1cfeda4b9
maflcko commented at 8:51 AM on April 7, 2024: member

lgtm ACK 93fae5ae7c31fa1b1095770f00adeac1cfeda4b9
fanquake merged this on Apr 7, 2024
fanquake closed this on Apr 7, 2024
theStack deleted the branch on Apr 7, 2024
Pttn referenced this in commit b4553c4783 on Apr 13, 2024
PastaPastaPasta referenced this in commit 38237e84eb on Oct 25, 2024
Fabcien referenced this in commit 7fbc409146 on Nov 12, 2024
roqqit referenced this in commit e9574980a0 on Nov 21, 2024
bitcoin locked this on Apr 7, 2025

Type	Reviewers
ACK	brunoerg, maflcko

Contributors

Labels

Linked (view graph)

#26970 test: fix immediate tx relay in wallet_groups.py #27114 p2p: Allow whitelisting manual connections

test: remove immediate tx relay workaround in wallet_groups.py #29822

Code Coverage

Reviews