Introduce a usage of std::source_location.
I thought this had been/was blocked on the macOS SDK.
fuzz: use std::source_location in fuzz/rpc.cpp #29841
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:introduce_source_location changing 1 files +4 −2-
fanquake commented at 7:34 AM on April 10, 2024: member
-
fuzz: use std::source_location in fuzz/rpc.cpp 11b8a88b38
-
DrahtBot commented at 7:34 AM on April 10, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
- DrahtBot added the label Tests on Apr 10, 2024
-
maflcko commented at 7:43 AM on April 10, 2024: member
-0 on this refactor. The existing code seems easier to read and is shorter?
Also, albeit not an issue here, when used as default argument the location is wrong, see https://github.com/llvm/llvm-project/issues/56379.
-
fanquake commented at 7:45 AM on April 10, 2024: member
The existing code seems easier to read and is shorter?
Yea, I assumed this might be one pushback. I guess the project can decide if this is actually something we want to use in general. Or, if the tradeoff in verbosity is only worth it when used more globally.
-
fanquake commented at 7:47 AM on April 10, 2024: member
Actually, will just come back to this after Clang 16.
- fanquake closed this on Apr 10, 2024
-
- fanquake deleted the branch on Apr 15, 2024
- bitcoin locked this on Apr 15, 2025
